Chris Rizzitello
Chris Rizzitello
The fact that you would even suggest all options for cmake need to go in a preset should how little you understand cmake. we don't want all options in preset...
>Having CMAKE_WARNINGS_AS_ERRORS defaulted on for developers is very important to ensure warnings don't creep in, which happens all too easily without people noticing. Sure this is in CI, but having...
the presets will be auto loaded by most IDE so you are forcing them on all.
They will all by default use the preset and the user has to do extra stuff to opt out.
I think my objection here boils down to this It is simply not our place to set any of these for the user, The more you hide settings and options...
Next time lets get all these Nits Before the code lands. I really don't like fixing commit nits with more commits
vcpkg should copy all the stuff to the deployment for you . Check to see if your ide has this option and if its on.
> > If you wanna exit when settings are cleared then tell the user you cleared the settings then exit. > > You're missing the point. Exiting the app, or...
> > Then fix the settings so restart is not needed.. Cause when we do that this code is now useless... > > What are you proposing exactly? Somehow reset...
@nbolton did you resolve this with the linked pr ?