Siteshwar Vashisht

> Let's wait for a week or so in case @siteshwar has any comments on this. I had a quick look at it. LGTM.

> @siteshwar Could you please stop pushing your commits after every single change you make? It is spamming my mailbox. Thank you! (If you want to resolve each review comment...

> I find the use of `stdout`/`stderr` in `worker-manager` inconsistent. I think it should use `stdout` for output that is processed by the caller and `stderr` for diagnostic/progress output. I...

@kdudka @lzaoral Can you take another look at this pull request?

This script has been in production since April. A couple of mass scans have been performed through it, and Packit integration also seems to work reliably. I propose we should...

> @siteshwar I can see you rebased the pull request but the above review comments have not been addressed? I am deploying to Fedora infrastructure from this branch, so I...

> (Also mentioned by Tomáš in #211 ) As I understand, this comment was about running scan on a locally created SRPM and not about specifying a remote URL.

One way to implement this functionality is to download the SRPM [directly](https://github.com/openscanhub/openscanhub/blob/bd8475834908a317f552cb9321e24b2da46721b1/osh/worker/tasks/task_build.py#L84) in the workers. But in that case the srpm would not be archived by hub. We should discuss...

> @siteshwar If we want to get the SRPM archived by OSH (although I am not insisting on that), this can be initially implemented in `osh-cli` (and eventually optimized later...

> I agree this might be a concern in general but the Copr URL Packit wants to use should be unique. > > I think it's ok to leave it...