Siteshwar Vashisht

Results 113 comments of Siteshwar Vashisht

https://github.com/openscanhub/openscanhub/pull/301

> [openscanhub/openscanhub#301](https://github.com/openscanhub/openscanhub/pull/301) These changes are in production now. Example messages: ``` [INFO fedora_messaging.twisted.consumer] Successfully consumed message from topic org.fedoraproject.prod.openscanhub.task.started (message id f6561b12-a1d3-4567-9f72-2ef3b941210a) [INFO fedora_messaging.twisted.consumer] Consuming message from topic org.fedoraproject.prod.openscanhub.task.started (message...

As of now, this pull request contains some non-functional code and there may be some code duplication. But I am opening it to stay in sync with the Packit team...

The checks are passing now, so I am marking this pull request ready for review. There may still be some missing code, but I would not know it until these...

// Self Notes Integration test example: https://github.com/packit/packit-service/blob/11d4722765650d350cab89ba8ec80fcfd0736cfa/tests/integration/test_listen_to_fedmsg.py Unit test example: https://github.com/packit/packit-service/blob/11d4722765650d350cab89ba8ec80fcfd0736cfa/tests/unit/test_open_scan_hub.py

> * `fail_ci_on_new_findings` should cause CI to become red on new findings. On a second thought, the status should not be "fail", it should be "action_required" on new findings. Also,...

This may be more complicated then it looked initially, as we plan to upload SARIF to CodeQL and it has its own [checks](https://docs.github.com/en/code-security/code-scanning/managing-code-scanning-alerts/triaging-code-scanning-alerts-in-pull-requests#code-scanning-results-check-failures) for severity of the findings that determines...

> Can't the CodeQL replace the checks? 🤔 It seems configurable, but the default setting hides results from the user. We can only keep the `osh-diff-scan` check and avoid uploading...

> On a second thought, the status should not be "fail", it should be "action_required" on new findings. Also, it should be "neutral" if there is a new finding, but...

Add [polkit](https://github.com/polkit-org/polkit/pull/527) to the list.