Sital Kedia

Results 18 comments of Sital Kedia

@ikabiljo - Possible to split this into two PRs for easier review? I see its addressing two different functionalities one for each commit?

> First of all, is this a PR for [aggregate signatures or multisignatures](https://docs.google.com/presentation/d/1G4XGqrBLwqMyDQce_xpPQUEMOK4lFrneuvGYU3MVDsI/edit#slide=id.g1246936523c_0_101)? @alinush - This is for multi-sig support. I will rename the structures for clarification.

There are multiple changes in this PR. Can you update the PR description accordingly?

@areshand - Can you clarify which schema in DB you are referring to? Is it the execution status stored in `TransctionInfo` https://github.com/aptos-labs/aptos-core/blob/main/types/src/transaction/mod.rs#L1014 ?

@ibalajiarun - As a follow up from this, can you make sure to add/update the grafana dashboards to monitor these newly added metrics?

The changes look good to me but can you provide more context on why is this needed? Also, update the PR description accordingly.

@grao1991 - Do you have a successful run for this test? If so, can you point to the link? Also, can you update the test plan accordingly?

You might also want to add github workflow yaml file to let this run in continous mode?

@StephenRossRepublic - Try setting the value to 3000 for mempool_backlog.

@JoshLind - Can we summarize the improvements we saw - may be volume of the data as well as the speed of state sync after compression is enabled?