BayesNets.jl icon indicating copy to clipboard operation
BayesNets.jl copied to clipboard

Making Pluto Compatible

Open Karthik-avj opened this issue 2 years ago • 4 comments

Added compatible for Pluto.jl as mentioned in https://github.com/sisl/BayesNets.jl/issues/145.

Karthik-avj avatar Apr 26 '23 10:04 Karthik-avj

Codecov Report

Merging #151 (04d965f) into master (080b396) will not change coverage. The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master     #151   +/-   ##
=======================================
  Coverage   85.74%   85.74%           
=======================================
  Files          41       41           
  Lines        2014     2014           
=======================================
  Hits         1727     1727           
  Misses        287      287           
Flag Coverage Δ
unittests 85.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Apr 26 '23 10:04 codecov-commenter

All that is required is adding Pluto as a dependency? I'm not sure we want that. If we actually need it, can it be a weak dependency loaded as a package extension (introduced in Julia 1.9)?

mykelk avatar Dec 31 '23 23:12 mykelk

I agree with Mykel. @Karthik-avj could you explain how adding Pluto to the Project.toml helps make BayesNets compatible? You can already add BayesNets to any Pluto notebook without this addition.

mossr avatar Jan 01 '24 00:01 mossr

@Karthik-avj This is a Pluto plotting issue and not a dependency issue with BayesNets.jl.

mossr avatar Jan 22 '24 05:01 mossr