Brian Smith
Brian Smith
My initial thought is to have something like a `.secretpatterns` file that is similar to the `.gitignore` file where each line is a new pattern. `ripsecrets` would look in the...
All the patterns are defined by regex currently, and that's what makes it so fast, so I would definitely want to start with custom regex patterns.
@colindean thanks Colin! I saw that authors aren't supposed to submit their own project so I'd appreciate it :-)
> Currently, there's only one benchmark. It basically runs find_secrets on the ripsecrets directory itself (I think?) I think if we have benchmarks we should have test files that it...
Could the benchmark check out the repo at a particular rev when it's run?
I don't have a strong opinion about the code organization. I'm not a rust expert and I find the code organization primitives a bit confusing honestly.
Thanks @colindean, I really appreciate it!
@pkgh-mp secrets in URLs should probably be supported by default. I can take a crack at adding that soon. @kengodwin I can also look at adding custom regex patterns to...
I just published a new release that allows you to specify additional secret regexes using the `--additional-pattern` CLI argument. I chose against having a config file for now since if...
Hmm, it looks like the Windows tests are failing for some reason. From looking at the test I don't see any obvious reasons why it should be failing when it...