Erik Sipsma

Results 74 comments of Erik Sipsma

> Yeah. Not so sure what people want to do with the PIDs. The .proto file doesn't explain the semantics much. > > https://github.com/containerd/containerd/blob/faec567304bbdf6864b1663d4f813641b5880a4a/runtime/v2/task/shim.proto#L168 Yeah, just going by its use...

Sounds good, thanks @Zyqsempai !

We have not yet integrated our tests with Firecracker, it's still something we should setup when someone has free bandwidth to do so

We should also update the getting-started guide and/or other docs with details on how to use the jailer

Agree about users having the ability to collect all systemd logs. I think it's worth seeing if we can find a way for systemd journal logs to get streamed out...

> [Here](https://github.com/googleapis/googleapis/blob/master/google/rpc/error_details.proto) are some generic error protos that are meant to go into that details field. Ah interesting, I didn't know those existed! Yeah maybe we could look into re-using...

> It looks like that error happens only if the value for the status is [OK](https://github.com/grpc/grpc-go/blob/master/status/status.go#L166). I think it can [here too](https://github.com/grpc/grpc-go/blob/7c3115d8bba8df106f26e55d52db456ed42893f8/status/status.go#L174) unless it's the case that `MarshalAny` will always...

> re: sending actual responses instead of empty responses: Is this something we might want to do anyways so we can add values here in the future in a backwards...

@mxpv Right, that's what I was suggesting, 2 separate kinds of retries, once for Firecracker to even start up the VM (which includes copying the rootfs image I'd presume) and...

It would require more investigation and very well may not end up being beneficial, but the *potential* benefit of 3 I was imagining would be if we want to be...