Pieter Wuille comments

Results 554 comments of


                                            Pieter Wuille

using sendtoaddress is calculating wrong/high fees

This looks like it's the same issue as https://github.com/bitcoin/bitcoin/issues/10247 upstream, which is actively being worked on.

Question

@real-or-random I think you mean Liquid rather than Lightning.

Public-key encryption module

@real-or-random Don't feed the trolls/bots/AIs.

net: Replace libnatpmp with built-in PCP+NATPMP implementation

Do we have any information about real-world deployment of PCP vs NAT-PMP? I see PCP dates from 2013, but do we know if it was adopted immediately (and/or, how many...

net: Replace libnatpmp with built-in PCP+NATPMP implementation

@laanwj Yeah, fair enough. Absent any reports of "doesn't work on my router while nat-pmp worked" (which we're quite unlikely to get) there is really no way to assess that.

net: Replace libnatpmp with built-in PCP+NATPMP implementation

Trying this with `-pcp=1` on my home internet connection: ``` 2024-05-20T23:28:41.625432Z [net] pcp: gateway [IPv4]: 192.168.1.1 2024-05-20T23:28:41.625469Z [net] pcp: Requesting port mapping for addr 0.0.0.0 port 8333 from gateway 192.168.1.1...

net: Replace libnatpmp with built-in PCP+NATPMP implementation

@laanwj This is a router provided by Verizon (a large US ISP) in 2021.

decoderawtransaction should use hex or decimal, not both

Duplicate of #27795 ?

dbwrapper: Bump LevelDB max file size to 128 MiB to avoid system slowdown from high disk cache flush rate

@jamesob Feel like benchmarking a reindex or so with this?

dbwrapper: Bump LevelDB max file size to 128 MiB to avoid system slowdown from high disk cache flush rate

It appears that RocksDb (more-developed derivative of LevelDB) uses a default of 64 MiB (https://github.com/facebook/rocksdb/blob/main/include/rocksdb/advanced_options.h#L468). See also my comment in https://github.com/bitcoin/bitcoin/pull/30059#issuecomment-2117888385.