Pieter Wuille

Results 554 comments of Pieter Wuille

I've included the first commit from here in #1169, as it simplifies things a bit there, but I'm happy for this PR to settle first.

> One potential issue with this is that when we write blocks to disk, we would be writing them without witness data. I think this could create a problem if...

@stratospher Rebasing on #28331 would let you revive this.

~~Since the merge of #29058 I think the first commit here should be dropped.~~ EDIT: nevermind, I confused `addconnection` with `addnode` (and the latter already has a `v2transport` argument).

What about not removing the existing years in notices, but adding ", and later (see source control)"? On the off-chance that there is some legal concern somewhere about changing existing...

@MarcoFalke Yeah, perhaps, IANAL. I'd like to see @real-or-random's comments addressed a bit more thoroughly before proceeding with anything really.

I agree with @real-or-random here; it really feels that just adding "-present" and then not updating further gets us 95% of the benefit, with only a fraction of the risks...

@sillsm Thank you for the comments. I'm however not convinced about one thing you bring up: > This should take care of concerns raised by "The above copyright notice and...

Added a commit, suggested by @achow101, to merge ToString and ToPrivateString completely.

@luke-jr I don't think that's exactly it. If you provide a SigningProvider which happens to not contain the necessary private keys, it'll also use public ones. So I think it's...