Shubham Sinha
Shubham Sinha
I think this is coming from a concept in Java where we can set values in a thread and access them as globals in that thread. This is not possible...
@kgabryje @lyndsiWilliams can you please review?
@zhaoyongjie @stephenLYZ @michael-s-molina can you please check this pr? It would be very helpful, it has been open since long.
@AAfghahi can you please check this pull request?
@hughhhh @zhaoyongjie @stephenLYZ @michael-s-molina can you please check this PR?
@villebro can you please check this?
@villebro I have updated the package lock file. The idea behind updating the package lock file is- 1. Just handlebars helpers usage was causing an issue saying `exports not defined`...
@villebro I am facing the issue with both MacOS and Linux. I understand this part that removing the dependency will avoid any fixes to be incorporated automatically in Superset, but...
@villebro I am using `node v16.16.0` and `npm v8.11.0`. Also, I have already added test cases around the functions I added.
@villebro thanks a lot for these iterations, it's just a healthy discussion and learning for me. Sure, lemme know whenever we can merge this, it has kind of been open...