singh733

Results 8 comments of singh733

@Tratcher I have dig into the code and figure out that we are calling at **_SameSite = SameSiteMode.None_** at 2 places a) https://github.com/dotnet/aspnetcore/blob/0f517603dc0cf996f58ccd67fd12b513794de5a4/src/Security/Authentication/OpenIdConnect/src/OpenIdConnectOptions.cs#L68-L76 b)https://github.com/dotnet/aspnetcore/blob/0f517603dc0cf996f58ccd67fd12b513794de5a4/src/Security/Authentication/Core/src/RemoteAuthenticationOptions.cs#L22-L32 I will make the changes for...

@Tratcher @davidfowl I have dig into the code and below are my findings: a) On line no 102 the exception is being logged when the browser close. https://github.com/dotnet/aspnetcore/blob/04bb460447cc6b84ec88080a777b298ba70ce7d7/src/Middleware/Diagnostics/src/DeveloperExceptionPage/DeveloperExceptionPageMiddlewareImpl.cs#L94-L108 b) When...

@Tratcher Do we need to do something like this: ```cs if (ex is BadHttpRequestException badHttpRequestException) { context.Response.StatusCode = badHttpRequestException.StatusCode; } else if (ex is OperationCancelledException operationCancelledException) { context.Response.StatusCode = operationCancelledException.StatusCode;...

@Tratcher, There is no OperationCancelledException Exception right now . Should I need to create the OperationCancelledException same as BadHttpRequestException. If yes, then a) How we get the CancellationToken property of...

@Tratcher Below is the proposed Solution for [DeveloperExceptionPageMiddlewareImpl](https://github.com/dotnet/aspnetcore/blob/main/src/Middleware/Diagnostics/src/DeveloperExceptionPage/DeveloperExceptionPageMiddlewareImpl.cs ) Please share your views. ```cs try { await _next(context); } catch (Exception ex) { if (ex is OperationCanceledException operationCanceledException && operationCanceledException.CancellationToken...

@Tratcher @davidfowl Below is the proposed Solution for [DeveloperExceptionPageMiddlewareImpl](https://github.com/dotnet/aspnetcore/blob/main/src/Middleware/Diagnostics/src/DeveloperExceptionPage/DeveloperExceptionPageMiddlewareImpl.cs) ```cs try { await _next(context); } catch (Exception ex) { if (ex is OperationCanceledException operationCanceledException && operationCanceledException.CancellationToken.IsCancellationRequested) { // TODO: Better...

> That's a ConnectionAbortedException and shouldn't be changed (what's it's log level?). Log Level is Debug b) Just Curious Do we need to handle both ConnectionAbortedException and OperationCanceledException, because ConnectionAbortedException...

@captainsafia Do you need any change from my side ?