simurai

Results 143 comments of simurai

> This CSS syntax highlighting is barely better than just plaintext Yeah, especially for `scss`: ```scss .class.one-more-class:hover { color: red; background-color: #123456; } ``` There is a discussion regarding the...

For reference https://github.com/primer/github-vscode-theme/issues/69#issuecomment-650467880

🔗 Cross-link to https://github.com/github/mobile/issues/3342 where GitHub Mobile is also considering using Primer CSS for Markdown styling.

> Is it the expected behaviour that we need to always enter a [GitHub] password to push the tag to the GitHub repo before publish will fully complete? Shouldn't it...

@danielbayley What do you get if you run `git remote -v`? I just had this problem too and when checking the remote push URL, I was using `https://[email protected]/username/repo.git`. Once I...

@tobiasahlin What's the status of this PR? Do we still wanna ship it? Sorry, there are now lots of merge conflicts because some component styles moved to PVC. E.g. -...

Note that the `.Box` styles moved to [Primer ViewComponents called `BorderBox`](https://github.com/primer/view_components/blob/3d2dc03fba0e98f01676e44aa7a76faf87812059/app/components/primer/beta/border_box.pcss). So we're probably gonna deprecate the `.Box` component at some point and use [`BorderBox`](https://primer.style/view-components/components/beta/borderbox) instead. Not sure if the...

Let's close this for now. Further improvements that could be done: - At some point switch to `system-ui`. Depends a bit on OS/browser adoption. - Let users choose their font,...

Closing this again since the [`.Banner` styles now live in PVC](https://github.com/primer/view_components/blob/50572b1a523129c560415eff6ec52dde121c78f8/app/components/primer/alpha/banner.pcss).

@heynan0 Thanks for the details. 🙇 We chatted about this today in our weekly meeting. Using a variable might be an option, but we think it's ok to just move...