Simonas Pinevičius

Results 12 comments of Simonas Pinevičius

Hi, @Koisell, thanks for PR. I see that `com_github_bazelbuild_buildtools` is used internally for `rules_scala` and I don't understand how it affects your code. Could you elaborate more? Are you willing...

I agree with @ianoc it's related to https://github.com/bazelbuild/rules_scala/pull/949 though it's interesting why proto paths are not unique and we see this only in windows. @amitz could you share a test-case/setup...

Hi @andrewhamon, This is not the answer to your question directly, but I want to share how we handle google protos. "Well known protos" (like `@com_google_protobuf//:timestamp_proto` and others) are precompiled...

@adam-singer I've created a repro https://github.com/simuons/rules_scala/tree/javabase-example/examples/jdk and got same failure `java.lang.NoSuchMethodError: java.nio.ByteBuffer.flip()Ljava/nio/ByteBuffer;` for command `bazel clean && bazel run --javabase=:jdk8 --host_javabase=:jdk11 :MainScala` I made it pass by changing `cfg="exec"` to...

Hi @ptarjan registered [scala_toolchain](https://github.com/bazelbuild/rules_scala/blob/master/docs/scala_toolchain.md) is used to compile `@io_bazel_rules_scala//src/scala/scripts:scalapb_worker_lib` so you could setup `scalacopts` to suppress these deprecation warnings. Ideally there should be no warnings from internal targets. Which version...

Hi @wisechengyi, thanks for reporting this. The issue is that there is a [check if sources are provided](https://github.com/bazelbuild/rules_scala/blob/master/scala/private/phases/phase_compile.bzl#L169) and depending on the presence of sources jars are build differently. [_build_nosrc_jar](https://github.com/bazelbuild/rules_scala/blob/master/scala/private/phases/phase_compile.bzl#L251)...

Hi @purkhusid, currently at wix we use aspects based rules. But right now we are moving to combination of aspects based rules for messages and custom rules for services. We...

@purkhusid > Would it be something similar to what I'm trying to accomplish here: #1114 ? Yes it looks very similar. In addition I need ability to change generator and...

@purkhusid have you tried this rule on your code base? I'm wondering how many other requirements would pop up. I think with this rule you would need to replicate whole...

> Any pointers on how to to limit the transitive dependencies in the compilation? I think this is the place where all transitive deps gets merged https://github.com/bazelbuild/rules_scala/pull/1114/files#diff-65fac07922564e63374c6db4871ef5dcR44