Shota Yamazaki

@kiskoza Thank you for your contribution. We’ll wait for a new Rails release for a moment, as discussed in #166. I think we should add a description for whitelisting of...

Thank you for your contribution! I think this requested feature is clear, but just wonder what its use cases are. Are there any use cases you would like to nullify...

I think this requested feature is clear, but just wonder what its use cases are. Are there any use cases you would like to nullify notifiable, not deleting notifications? Notifications...

In addition, *Notification* model has a validation for presence of notifiable. https://github.com/simukappu/activity_notification/blob/master/lib/activity_notification/orm/active_record/notification.rb#L51 If we add this *nullify_notifiable* dependent option, updated notification records will be invalid. We have to consider and...

Hi @apuntovanini Thank you for your feedback, and sorry for my late reply. I think your suggestion make sense. We probably should allow subscriber model to define the name of...

Hi @apuntovanini Sorry for my late reply. Thank you for creating test PR, and I understood you’ve created fork for this patch. I will investigate an impact of renaming the...

@apuntovanini If you could draft a PR, it would be helpful. Can you create it?

Thank you for your PR. I've checked it. I understand the issue and request, but it seems to be difficult to make this subscription association name configurable. The changes of...

This makes sense. Is it OK to add the option which *Mailer* will ignore them or just create logs without sending email when *Notification* record cannot be found?

Current work around is customizing your own [mailer implementation](https://github.com/simukappu/activity_notification/blob/master/app/mailers/activity_notification/mailer.rb) or using [optional target](https://github.com/simukappu/activity_notification#optional-notification-targets).