Simon Willison
Simon Willison
A few tests are failing with errors like this: ``` def test_publish_cloudrun_extra_options( mock_call, mock_output, mock_which, extra_options, expected, tmp_path_factory ): mock_which.return_value = True mock_output.return_value = "myproject" runner = CliRunner() os.chdir(tmp_path_factory.mktemp("runner")) with...
Good catch, thanks.
`insert-row: true` permission at the table level should over-ride `insert-row` at the database level
Suggestion [from Discord](https://discord.com/channels/823971286308356157/823971286941302908/1275662057877934193): > In `datasette/default_permissions.py` the function `_resolve_config_permission` first checks for any database specific permissions blocks that match, and if that returns `False`, then it fails. IF there is...
`insert-row: true` permission at the table level should over-ride `insert-row` at the database level
Code in question: https://github.com/simonw/datasette/blob/1f3fb5f96b3f6e773b8c1b8ec5d8f7516c6860b0/datasette/default_permissions.py#L174-L230 Documentation: https://github.com/simonw/datasette/blob/1f3fb5f96b3f6e773b8c1b8ec5d8f7516c6860b0/docs/authentication.rst
`insert-row: true` permission at the table level should over-ride `insert-row` at the database level
Tests: https://github.com/simonw/datasette/blob/1f3fb5f96b3f6e773b8c1b8ec5d8f7516c6860b0/tests/test_permissions.py
`insert-row: true` permission at the table level should over-ride `insert-row` at the database level
Said to Claude Code: > `Read https://github.com/simonw/datasette/issues/2402 and conduct an experiment to see if the problem is still valid` Claude thinks this is fixed: https://gistpreview.github.io/?275a38450eb9a23c3da667d4bb821e3c It wrote and executed this...
`insert-row: true` permission at the table level should over-ride `insert-row` at the database level
I tested manually - I dropped this in `datasette.yaml`: ```yaml databases: my-db: permissions: insert-row: id: [root, admin] allow: id: [root, admin] tables: my-table: permissions: insert-row: true ``` Then ran this:...
This is a great idea - I've wanted this myself before, but never spent any time thinking about how to achieve it. I think your design here is exactly right...
To land this change we'll need a unit test that demonstrates the new capability - I suggest putting that next to this test: https://github.com/simonw/datasette/blob/15a9d4abfff0c45dee2a9f851326e1d61b1c678c/tests/test_plugins.py#L648-L659 It will also need documentation, which...
I absolutely _love_ this performance boost - really nice find. One concern: this will be the first time Datasette ships a core feature that uses window functions. Window functions were...