Simon Willison

Results 2777 comments of Simon Willison

Design options: 1. Any tables that cannot be read by `PRAGMA table_info()` are excluded by Datasette entirely - it's as if they do not exist 2. Those tables are listed...

OK, this is actually a lot of work to implement. I tried this so far: ```diff diff --git a/datasette/utils/__init__.py b/datasette/utils/__init__.py index 073d6e86..5469252b 100644 --- a/datasette/utils/__init__.py +++ b/datasette/utils/__init__.py @@ -19,6 +19,7...

This would be a bit easier if I moved all code in Datasette that loops through a list of tables to consult the internal database catalog tables for those, then...

That broke on a macOS test: https://github.com/simonw/datasette/runs/5044036993?check_suite_focus=true I'm going to remove macOS and Ubuntu and just try Windows purely to see what happens there.

OK, the tests do NOT pass against Windows! https://github.com/simonw/datasette/runs/5044105941

This is a very neat fix, for something I've been wanting for a while. Add a unit test for the row HTML page - I suggest against this page: https://latest.datasette.io/fixtures/foreign_key_references/1...

> I've implemented the test (thanks for pointing me in the right direction!). > > At [tmcl-it/datasette:0.64.1+row-view-expand-labels](https://github.com/tmcl-it/datasette/tree/0.64.1%2Brow-view-expand-labels) I also have a variant of this patch that applies to the 0.64.x...

I should update the documentation to reflect this change.

Also need to do a bit more of an audit to see if there is anywhere else that this style should be applied.

I prototyped this like so: ```diff diff --git a/asgi_proxy/__init__.py b/asgi_proxy/__init__.py index 98ab369..af8c8e5 100644 --- a/asgi_proxy/__init__.py +++ b/asgi_proxy/__init__.py @@ -17,6 +17,8 @@ def asgi_proxy(backend, log=None): # Replace host header headers["host"] =...