Simon Pasquier

Results 601 comments of Simon Pasquier
trafficstars

v0.4.0 is the latest official [release](https://github.com/prometheus/collectd_exporter/releases) of the exporter.

It was https://github.com/prometheus/common/issues/128

There would need to be a new release of the exporter. In the meantime you could use the `master` tag.

It looks like the underlying implementation of [`Do()`](https://github.com/prometheus/client_golang/blob/84c6b9db90c01eae0373263aa46088a0850c7724/api/prometheus/v1/api.go#L924-L931) already checks the HTTP response code. From what I can tell no caller of the `Do()` and `DoGetFallback()` functions (from the [`apiClient`](https://github.com/prometheus/client_golang/blob/84c6b9db90c01eae0373263aa46088a0850c7724/api/prometheus/v1/api.go#L879-L883)...

@LeviHarrison do you want me to pick up the work? This bug is becoming a significant issue for us right now.

Rebased on top of main, I didn't change anything to the PR except for resolving the conflicts. Thanks a lot @LeviHarrison!

I did a quick check and `http://user:[email protected]` doesn't work (which looking at `httputil.NewSingleHostReverseProxy` is logical). I think that your request makes sense. Maybe users should be able to configure additional...

> is it by design, that the value of the label to be checked for cannot be specified directly here, and instead I'll need to put another reverse-proxy between prometheus/thanos...