common icon indicating copy to clipboard operation
common copied to clipboard

Unmarshal URL's with urls.redacted

Open roidelapluie opened this issue 5 years ago • 4 comments
trafficstars

I propose that since go 1.15 supports url.Redacted, we make used of it while unmarshaling urls.

This could be done my adding a URL wrapper in this repo.

https://github.com/golang/go/issues/34855

roidelapluie avatar Jul 21 '20 10:07 roidelapluie

We provide a way that occludes secrets for basic auth, do we really need this? Also the way Go occludes is different to the way we do it in terms of placeholder, which would be confusing.

brian-brazil avatar Jul 21 '20 10:07 brian-brazil

We do not provide a way to do Proxy Authentication.

roidelapluie avatar Jul 21 '20 11:07 roidelapluie

Then that is something we should discuss, I think there's an issue for it lying about somewhere.

brian-brazil avatar Jul 21 '20 13:07 brian-brazil

It was https://github.com/prometheus/common/issues/128

simonpasquier avatar Jul 24 '20 14:07 simonpasquier