Simon Pasquier

Results 951 comments of Simon Pasquier

oh wait! Would this work as you expect? When I tried locally, I get `rm: invalid option -- 'g'` which makes sense looking at this part. https://github.com/prometheus/alertmanager/blob/ec2f5f589402d8b45e327555d1330ce780354221/ui/app/Makefile#L58-L61

Your best bet is to turn on debug logs (`--log.level=debug`). How do you know for sure that notifications are missing?

@andrewipmtl > Shouldn't all alerts route to the default route (which is set as the webhook)? no, alerts that will match the `Test Presence Offline Notification Name` receiver won't go...

@mvineza this seems a different problem. > For example, if there is an active alert containing 5 nodes grouped together. > > We will receive 2 POST request. The first...

@andrewipmtl can you share the new config?

@andrewipmtl hmm not sure why you configured a subroute. AFAICT this would work the same? ``` route: receiver: device-alerts.hook group_by: - alertname - uid - group_id - stack_name - tenant_id...

Ok not sure why this happens but the only thing I can recommend is to run with `--log.level=debug` and investigate what happens when no notification is sent while you expect...

> Should we fail? Or just it should match the empty value? not feeling strongly on this one but as the parser is already quite liberal ([example](https://github.com/prometheus/alertmanager/blob/3f3e2ce4dac4090a5ce7361e50d09b14c7dea313/pkg/labels/parse_test.go#L168)), I would ok...

:wave: could you split the change into several pull requests. There are things that make sense to me but others that would need prior discussion and agreement. > Add validation...

This isn't the first time that the ability to log alerts or notifications has been requested (see https://github.com/prometheus/alertmanager/issues/1042 for alerts). I see that using webhook + `continue: true` as we've...