Simon Ihmig
Simon Ihmig
I assume this is in a test, that has `setupWindowMock(hooks)` called in its parent `module`? Again here, this has [test coverage](https://github.com/simonihmig/ember-window-mock/blob/master/test-app/tests/unit/run-window-tests.ts#L72), so I tend to assume something specific to your...
The failing test is a weird one: there is an unexpected file (`./mod/index.js,`) in the scenario-tester project that fails the test. However, this file seems to be generated in a...
> The failing test is a weird one: there is an unexpected file (./mod/index.js,) in the scenario-tester project that fails the test. @mansona I think when we discussed this PR,...
I see, thank you @mansona! So next step is getting us to `4.0.0` here, right? This was only flagged a major because you could rely on the wrong behaviour that...
Tried to upgrade `scenario-tester` to v4 today, but getting a good amount of TS errors:  We are on a very outdated version of TS here (4.3.5), probably we have...
With updates to TS and scenario-tester merged and this one rebased, this is now finally having a green build! :tada: Thus ready for a final review! cc @ef4 @mansona
Yeah, absolutely. I don't think I have the time to do this, but a PR would certainly be welcome! :)
Thanks for bringing this up! I think this should be done also for the other packages in https://github.com/CrowdStrike/ember-headless-form/tree/main/packages?
LGTM! But the repo is not in a good shape, the failure is not related to your PR. I wanted to look at this, but haven't yet found the time...
We are getting hit quite hard by this, so many Renovate PRs failing due to flakiness. It seems though this is not happening only for the lit app, I see...