ember-headless-form icon indicating copy to clipboard operation
ember-headless-form copied to clipboard

Remove unneeded peer dependencies

Open NullVoxPopuli opened this issue 9 months ago • 3 comments

is extraneous, and the embroider/auto-import infra know where to get ember-source from. It's not wrong to include, but it requires folks' manage their deps correctly -- so we can be a little more forgiving to maintainers by just omitting this.

From PR descriptions elsewhere:

  • ember-source: removed because the embroider / auto-import know what we intend - it's not bad to have if someone manages their dep graph correctly, which is easier with pnpm, but not everyone gets it right, and folks have a hard time tracking down errors
  • @glimmer/tracking removed because it's a real package, but one we don't want to use. This comes up in embroider/vite where the presence of real packages always takes precedence over virtual packages. This is actually problematic because it can break reactivity in subtle ways, even if a dep graph is correct - allowing duplicates of dependencies, which for the glimmer internals, we don't want.

Related:

  • https://github.com/adopted-ember-addons/ember-sortable/pull/620
  • https://github.com/ember-cli/ember-app-blueprint/pull/7
  • https://github.com/ember-cli/ember-cli/pull/10697
  • https://github.com/ember-cli/ember-addon-blueprint/pull/35
  • https://github.com/embroider-build/addon-blueprint/pull/339
  • https://github.com/ember-polyfills/ember-functions-as-helper-polyfill/pull/151
  • https://github.com/jelhan/ember-style-modifier/pull/312
  • https://github.com/jmurphyau/ember-truth-helpers/pull/211
  • https://github.com/ember-modifier/ember-modifier/pull/949
  • https://github.com/tracked-tools/tracked-toolbox/pull/211
  • https://github.com/emberjs/ember-test-helpers/pull/1543
  • https://github.com/NullVoxPopuli/ember-resources/pull/1189
  • https://github.com/NullVoxPopuli/ember-modify-based-class-resource/pull/20
  • https://github.com/universal-ember/kolay/pull/187
  • https://github.com/universal-ember/reactiveweb/pull/139
  • https://github.com/universal-ember/ember-primitives/pull/471
  • https://github.com/universal-ember/docs-support/pull/77

NullVoxPopuli avatar May 11 '25 02:05 NullVoxPopuli

Thanks for bringing this up!

I think this should be done also for the other packages in https://github.com/CrowdStrike/ember-headless-form/tree/main/packages?

simonihmig avatar May 13 '25 17:05 simonihmig

⚠️ No Changeset found

Latest commit: 87de89d39d701c978321d5ab36220efa80e3defd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar May 13 '25 17:05 changeset-bot[bot]

ye! added!

NullVoxPopuli avatar May 13 '25 17:05 NullVoxPopuli

Right now anyone using @glimmer/component v2 must patch ember-headless-form, ie: https://github.com/universal-ember/ember-primitives/blob/main/patches/ember-headless-form.patch

NullVoxPopuli avatar Nov 30 '25 20:11 NullVoxPopuli