Simon Hampton

Results 110 comments of Simon Hampton

I'm a fan of TypeScript but dont know when or if I'll get round to using it (and adding a compiled version for js users)

that works be great can I suggest that you try not to change the code beyond adding the types. you may well see refactorings and improvements to the algorithm, but...

this is making me rethink my interest in typescript https://devclass.com/2023/05/11/typescript-is-not-worth-it-for-developing-libraries-says-svelte-author-as-team-switches-to-javascript-and-jsdoc/ What do others think

Thanks for this PR. I missed this at the time, but the change has been made now

These PR requires an explanation of what it is trying to do, and it also needs more information in the README

Can you say what happened, and what you expected to happen. I don't try to do much about time outs as they are out of my control

In #62 a possibly similar error was solved by adding `forcePasv: true` to the config - do you want to try that

Thansk,hopefully will have some time around xmas to review

Apologies for the delays. I forget about these things, but the underlying issue is that I do not use eslint nor editorconfig so reveiwing first mans learnign what they are...