ftp-deploy icon indicating copy to clipboard operation
ftp-deploy copied to clipboard

Published 20 hours ago • verified publisher icon simonh1000

Define `mkDirExists`

Open Sarrus1 opened this issue 2 years ago • 1 comments
trafficstars

When building a project with esbuild 0.18.15 that imports ftp-deploy, and running on Node 16, the program will exit because mkDirExists is not defined.

Unless I am mistaken, I do not see why mkDirExists needs to be an arrow function and most importantly, where the mkDirExists variable is declared before the assignment.

This PR fixes the issue by changing the mkDirExists declaration to respect the style of the other functions above.

Sarrus1 avatar Jul 22 '23 11:07 Sarrus1

This is fixed by #166, see: https://github.com/simonh1000/ftp-deploy/blob/149f6dca75bff65b893fc6c56ed9540e8425b436/src/lib.js#L129

@simonh1000: This PR can be closed.

cyrdam avatar Jul 17 '24 08:07 cyrdam

Thanks for this PR. I missed this at the time, but the change has been made now

simonh1000 avatar Aug 02 '24 11:08 simonh1000