Simon Ferquel
Simon Ferquel
2 notes here: - Unfortunately, VoidAsyncMethodBuilder seem to allocate unfortunately - at least in Mono, so I'd prefer we avoid async void methods - Returning an Awaitable that is not...
Just asking for confirmation: if I have a custom MSBuild SDK (that extends the .net SDK) will I be able to use those paths instead of relying on nuget to...
@thaJeztah - problem with config, is that the option struct itself assumes it references files. So we would need to modify everything with the assumption that everything has already been...
From what I read about io.Reader, it is a correct behavior to defer io.EOF until there is 0 bytes to read. So I think it is good enough.
I don't think we can handle the readat contract without handling the chunking inside client.Read (and if we do that, I would expect client.Write to do the chunking as well)...
That is the approach I took with my previous PR : make the client expose a MaxReadBufferSize and MaxWriteBufferSize.
For now this feature is a bit out of scope (it involves much coding: handling all the possible file types that you have in your library, + indexing / keeping...
Actually, if you don't change the import quality since it was previously downloaded, the actual "downloading" should be skipped (it appears in the download list, but when treated, it vanishes...
Thanks for the feedback, I'll split it in 2 items
In this context, hard to discover means also "easy to forget"