simonfelding
simonfelding
wow this sucks. spent so much time trying to figure out wth was going on here. please fix, or just say gitlab is unsupported.
Hi @orta, I'd love to. I can tell you exactly what the problem is. https://github.com/danger/danger-js/pull/1098 introduced the use of an enterprise edition API, which breaks danger for all community edition...
~~I investigated a bit and it appears that the reason the bug was introduced to begin with is that gitlab.com doesn't use project IDs.~~ ~~Is it unacceptable to just use...
I'm getting a 404 with the project name in the url, but 200 with the project id in the url, so maybe this isn't actually the right issue for it....
@MonolithProjects I fixed the conflicts, is it okay now?
I have the same patch ready for danger-js, if this one is acceptable.
This would be really good to have.
This is in reference to this line: https://github.com/grafana/loki/blob/c9c0e9a5282b9fc07604c3b257358693df8f4aaa/production/helm/loki/values.yaml#L114
Also solves https://github.com/grafana/loki/issues/11391
@MichelHollands Thanks for the quick response. I've tried running `make -C docs sources/setup/install/helm/reference.md` as the CI step says, but it doesn't change anything so there is nothing to commit. Any...