loki icon indicating copy to clipboard operation
loki copied to clipboard

fix: add extraEnvFrom to the global variables in the helm chart

Open simonfelding opened this issue 10 months ago • 5 comments

What this PR does / why we need it: Makes the helm values.yaml work like the documentation in values.yaml says it does.

Which issue(s) this PR fixes: N/A

Special notes for your reviewer:

Checklist

  • [x] Reviewed the CONTRIBUTING.md guide (required)
  • [ ] Documentation added
  • [ ] Tests updated
  • [x] Title matches the required conventional commits format, see here
  • [x] Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • [x] For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • [x] If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

simonfelding avatar Apr 17 '24 13:04 simonfelding

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Apr 17 '24 13:04 CLAassistant

This is in reference to this line: https://github.com/grafana/loki/blob/c9c0e9a5282b9fc07604c3b257358693df8f4aaa/production/helm/loki/values.yaml#L114

simonfelding avatar Apr 17 '24 13:04 simonfelding

Also solves https://github.com/grafana/loki/issues/11391

simonfelding avatar Apr 18 '24 09:04 simonfelding

@simonfelding Thanks for this contribution. The documentation hasn't been updated as mentioned in the failing CI step. Can you fix this? Once that is done I'll merge this.

MichelHollands avatar Apr 19 '24 14:04 MichelHollands

@MichelHollands Thanks for the quick response. I've tried running make -C docs sources/setup/install/helm/reference.md as the CI step says, but it doesn't change anything so there is nothing to commit. Any clues on what to do?

simonfelding avatar Apr 23 '24 13:04 simonfelding

@MichelHollands ping :)

simonfelding avatar May 06 '24 10:05 simonfelding

@MichelHollands ping :)

Can you remove that file and rerun the make step? Also please update the version everywhere.

MichelHollands avatar May 06 '24 11:05 MichelHollands