Simon Wang

Generated Code Examples: ValidateTest.thrift ```thrift /* * Licensed to the Apache Software Foundation (ASF) under one * or more contributor license agreements. See the NOTICE file * distributed with this...

> @GuangmingLuo none of the travis test passed, it doesn't look the compiler code compiles, so maybe fix that first? > > also in my previous comment I said that:...

> Feedback on the compiler generated go code: > > 1. I thought we agreed on [THRIFT-5423: Support go parameter validation in IDL #2469 (comment)](https://github.com/apache/thrift/pull/2469#discussion_r858950006) to use `TApplicationException` for validation...

> `Validate() error` is probably a better name. Sounds a better practice, fix done.

@fishy There is a `concurrency_test` error in AppVeyor, but I can't reproduce it locally. Is that an occasional case or does it fails due to my changes? And all fixes...

> The code is generally OK, minor issues aside. > > > We are adding a new `VALIDATION_FAILED` to `TApplicationException` > > This should be fine, I can't think of...

> > I add a supported functions table to the validator proposal, which can be modified when more functions or language supports are available. > > Looks good. Before we...

> Another suggestion, which can be done in a follow-up PR instead, but doing it in this PR will help a lot of the test code: > > Define a...

@fishy All fixes done, PTAL

Are there any updates? This would be very convenient to view the source code of packages imported. Especially when I have to search within imported packages, now I have to...