Andrew Simms comments

Results 38 comments of


                                            Andrew Simms

In `wave.resource.surface_elevation` use `sum_of_sines` method if input spectrum does not have a zero frequency

@akeeste, the latter is a great suggestion and simplifies the design. The latest changes remove `auto` and set `ifft` as the default method. If the method is `ifft` and the...

In `wave.resource.surface_elevation` use `sum_of_sines` method if input spectrum does not have a zero frequency

@akeeste [9b3bc3b](https://github.com/MHKiT-Software/MHKiT-Python/pull/309/commits/9b3bc3ba939e6dd3cc72c9091d128513686d48a0) changes the strategy for accessing the first frequency index value. Does that method seem more reliable for accessing the first value of the frequency index? I am seeing...

In `wave.resource.surface_elevation` use `sum_of_sines` method if input spectrum does not have a zero frequency

@ssolson, sorry for the poor timing of this PR. This does not need to be included in the latest release. Thank you!

In `wave.resource.surface_elevation` use `sum_of_sines` method if input spectrum does not have a zero frequency

@akeeste this is good to go now! The test failure in MHKiT-MATLAB is unrelated to this change. #313 adds a fix for the `dim_0` error.

`wave.resource.surface_elevation` does not gracefully handle input wave spectra where the zero frequency is not defined

@akeeste, good idea! I added a warning and a test in #309.

`wave.resource.surface_elevation` does not gracefully handle input wave spectra where the zero frequency is not defined

This issue was fixed in #309.

Add Delft3D Module

@browniea we are getting close to finishing up this PR. Could you take a look at the example livescript [here](https://github.com/MHKiT-Software/MHKiT-MATLAB/blob/885af62883478f3ce07db27b6c4d053edfd20840/examples/delft3d_example.pdf) and verify that everything looks OK? Our main questions are...

Add Delft3D Module

@browniea, thank you for the feedback. We have updated the colorbar to use discrete steps and added python function [`cleanup_turbulent_kinetic_energy`](https://github.com/MHKiT-Software/MHKiT-MATLAB/pull/124/commits/950bd22fb1cc3d70d1e24a9fedc2e1493f73f324). Can you take a look at the [MATLAB example notebook](https://github.com/MHKiT-Software/MHKiT-MATLAB/blob/c663cf2bc778f0672845dd0932d6479dcc4d645e/examples/delft3d_example.pdf)...

Add Delft3D Module

@rpauly18, any objections if we work on [ADCP_Delft3D_TRTS_Example](https://github.com/MHKiT-Software/MHKiT-Python/blob/develop/examples/ADCP_Delft3D_TRTS_example.ipynb) in a separate pull request? This notebook involves a combination of DOLfYN and Delft3D functionality, and to maintain the scope of this...

Add Delft3D Module

@browniea, apologies for the lack of clarity. The [`cleanup_turbulent_kinetic_energy`](https://github.com/MHKiT-Software/MHKiT-MATLAB/pull/124/commits/950bd22fb1cc3d70d1e24a9fedc2e1493f73f324) function is a part of this pull request. There are python functions within MHKiT-MATLAB (`mhkit_python_utils`) that handle some of the more...