simar7 comments

Results 396 comments of


                                            simar7

feat(misconf): add support for ARM resources declared with symbolic names

> Can I try this? first time. Sure go ahead!

feat(misconf): add support for ARM resources declared with symbolic names

@nikpivkin once you're back could you take a look?

feat(misconf): add support for ARM resources declared with symbolic names

> @simar7 I suggested moving support for the `Microsoft.Resources/deployments` resource to a separate PR, as it is not related to the resource declaration issue. WDYT? Yeah makes sense to me.

Upgrade trivy to v0.53.0

thanks for the PR, looks like we'll have to update the tests?

OCI runtime exec failed: exec failed: unable to start container process: exec: "bash": executable file not found in $PATH: unknown

hi @Dr-DevOps could you try the latest release of trivy-action? We've released some fixed that hopefully should address this. cc @DmitriyLewen

test(k8s): improve testing for k8s scanner

Any updated on this @afdesk

fix: Fix 'tf-var' arg not passing when using 'sarif' format

In order to support existing and future trivy options, we offer the ability to pass in a configuration file to the GitHub action. This allows users to not have to...

chore: switch to ID from AVDID in internal and user-facing fields

Overall LGTM just left one comment.

chore: switch to ID from AVDID in internal and user-facing fields

LGTM, I'll wait for others feedback as well.

feat(helm): add sslCertDir parameter

> > > @keliansb thanks for your contribution! I left some notes, WDYT? > > > > > > @afdesk I did the same configuration as the one already available...