Simone Orsi

Results 405 comments of Simone Orsi

> > > @qgroulard the 1st commit can be dropped now, no? > > > > > > In theory yes, the keys `price` and `prices` can coexist. > >...

@qgroulard can we fast track https://github.com/shopinvader/odoo-shopinvader/pull/1507 while fixing this one?

@lmignon as per #1493 here's a fix for access issue on the main model of the service. Could you have a look pls?

> @simahawk Why not adding `or None` when building the `SimpleProductPackaging` here: > > https://github.com/shopinvader/odoo-shopinvader/blob/5552357a8a34ff4814a9cbf1cd2af75e91adfd6c/shopinvader_product_sale_packaging/schemas/product_packaging.py#L24 > > I think it was forgotten there. It's on purpose. That was my first...

@PierrickBrun shall we reopen this?

> > ![image](https://private-user-images.githubusercontent.com/347149/321303477-2c24fab3-fab5-45a8-9c70-4a24e83ef34d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTI4MjE1NTAsIm5iZiI6MTcxMjgyMTI1MCwicGF0aCI6Ii8zNDcxNDkvMzIxMzAzNDc3LTJjMjRmYWIzLWZhYjUtNDVhOC05YzcwLTRhMjRlODNlZjM0ZC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNDExJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDQxMVQwNzQwNTBaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1iMWFmOTU5NzE4MjhhODBjNzVkMzFhMjc2YmNjODgyZTQ3MTQ3Njk5ZjIwZjdjNmVhZDYxYjhkNTVlNjFjMGU5JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.DRgFmiH6v8z8fc19F6ufc1tgVXUirols7HkOB6jtaMs) > > This test fails because we depend on `stock_picking_partner_note`, which currently has `note` as an Html field. As soon as we merge [OCA/stock-logistics-workflow#1543 (review)](https://github.com/OCA/stock-logistics-workflow/pull/1543#pullrequestreview-1992070362) , the...

> @flachica OK I understand now your point. The problem is wider. How can we deal with subpath into the root path at the same time of subpath in route?...

I have the same issue. In fact [this REGEX](https://github.com/madpah/requirements-parser/blob/master/requirements/requirement.py#L41) does not cover the simplest case: `-e path/to/package` . Of course, in such case we cannot get metadata. However, all we...