rest-framework icon indicating copy to clipboard operation
rest-framework copied to clipboard

[ADD] 14.0 base rest abstract attachment

Open PierrickBrun opened this issue 3 years ago • 4 comments

based on #206

PierrickBrun avatar Jan 12 '22 15:01 PierrickBrun

@qgroulard you may be interested in this one (for the images, maybe, or not)

sbidoul avatar Feb 08 '22 13:02 sbidoul

can't we name it only base_rest_attachment? I don't see the point of having "abstract" in the name :wink:

simahawk avatar Sep 01 '22 10:09 simahawk

@simahawk You're right I've renamed the module.

Thanks for the review, I've made the changes, the tests still do not pass, I will need to look into it again to make it work

PierrickBrun avatar Sep 30 '22 14:09 PierrickBrun

Also, I've used the same strategy as base_jsonifier to rename the module without breaking the installed databases so there is now and empty module inheriting the not empty one

PierrickBrun avatar Sep 30 '22 14:09 PierrickBrun

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Feb 26 '23 12:02 github-actions[bot]

@PierrickBrun shall we reopen this?

simahawk avatar Dec 05 '23 13:12 simahawk