Simon Podlipsky

~_I'll have to find a way to install php OCI drivers on m1 macbook to debug oracle failures_~ Solved

> I still don't get why you don't simply do this: > > ``` > $successful = false; > try { > $res = $func($this); > $this->commit(); > > $successful...

> Is that a thing that actually can happen? Yes, that's why we're getting `There's no active transaction` exceptions. It's covered in the added tests. Those exceptions come from the...

> -- this one happens when auto-commit is set to false and transaction nesting level is back to 0, and may fail for various reasons, I suppose I just checked...

> how it can happen > Network error? Database issue caused by some other program? yes, of course. I meant "how the wrong rollback" can happen in this code flow....

> > yes, of course. I meant "how the wrong rollback" can happen in this code flow. > > Let's say the network error happens and the opening of the...

> > > When autocommit=false, then calling transactional() increases nesting level to 2 and this line is never called > > > therefore, there does not appear to be any...

I think I have addressed @/derrabus' (not tagging explicitly to avoid noise) comments from previous attempt related to OCI and PDO_OCI https://github.com/doctrine/dbal/pull/4846#pullrequestreview-1761176225

Yup, though for the review process I wanted the commits to represent addressing the comments / explain the issue. Will consolidate + continue extracting.

I guess there's some issue with coverage configuration since e.g. my test explicitly covers this line