Simon Podlipsky

Results 337 comments of Simon Podlipsky

@Tobion afaik `implementations of the interface without the return type` are compatible ```php interface Foo { public function fcn() : iterable; } class Bar implements Foo { public function fcn()...

@dragonmantank any chance you could find a time and review this? Thanks!

The return type `Cron\CronExpression` is incorrect. As the class is not final, it is extensible. Therefore, when you extend it ```php final class MyOwnCronExpression extends \Cron\CronExpression ``` All static checks...

Hi @dragonmantank, the phpdocs are still incorrect. Can this be merged, please?

@dragonmantank :( > it does make it less clear what the factory returns. That's just false, it makes it precisely clear what it returns.

Unfortunately no, but it seems the referenced PR is a bit further ahead of this.

I'm experiencing the same issue via nextui You can see it here https://nextui.org/docs/components/date-range-picker#usage https://github.com/adobe/react-spectrum/assets/327717/5e1d2d3f-77e4-4ee5-92d3-3584f9853b1f It happens when you click into highlighted element ![image](https://github.com/adobe/react-spectrum/assets/327717/5973fadb-8101-40c1-be46-81e3438c6690)

It also happens on my internal project where I'm using nextui. Also, it happens only in their `date range picker` but not [`date picker`](https://nextui.org/docs/components/date-picker).

For me it's this one I guess https://github.com/adobe/react-spectrum/blob/8ed86d85f885b8a113fb51b000747839853ec6da/packages/%40react-aria/focus/src/FocusScope.tsx#L722

Aight, thanks! I'll migrate.