Silverweed
Silverweed
The proper solution would be to not make that function conditionally virtual, but that requires some thought and knowledge of the code which I don't have at the moment.. Silencing...
Superseded by https://github.com/root-project/root/pull/19070
I re-rebased the PR, this time making sure every single commit compiles independently (the first time I hoped that git would refuse to continue a rebase if there are still...
@makortel yes, it would be quite helpful, thanks :) @smuzaffar I rebased the PR, it should be goood now.
@vgvassilev should I close this PR or does it make sense to keep it open?
@vgvassilev what should we do with this PR?
Yes, I was wondering if we should keep pursuing this or not. If not I'll just close it rather than leaving it here unattended.
True, so probably it's best to restart fresh from the current state of things rather than rebasing an old fix without really understanding it like I did. That's why I...
@pcanal can this be merged?
> I left some high-level comments, but in general the PR is really hard to read and review because there are unrelated changes (both `using namespace` and formatting fixes) packed...