Nick Jennings comments

Results 170 comments of


                                            Nick Jennings

WIP: Port tests to Mocha and Chai

> ... I also talked to @galfert about this earlier. As it's a _ton_ of code to port, we agreed that it makes sense to share this work. Any and...

proposal: getting rid of claimAccess and displayWidget

I like the idea of having less public facing functions and more configuration via. parameters. That way it's easier for developers to find what they need and not go hunting...

proposal: getting rid of claimAccess and displayWidget

ping @michielbdejong - Do you think this issue is still relevant, or can we close it?

Conflicts getting ahead of queued pushes?

Sounds complicated :) I don't know enoug of this area of the code (and don't have a lot of expereince with syncing concepts in general) to be able to help...

Conflicts getting ahead of queued pushes?

yeah, sorry about that - i've since disabled that feature (was doing it automatically)

update local version of containing folder when a new items comes in from remote

Hey @michielbdejong, I thought I remembered that, on our last call, you said you'd make some unit tests to illustrate the issue, do you think you'll have some time to...

deleteChildPathsFromTasks looks wrong

ping @michielbdejong

getAll promise doesn't return data

I don't think we should close this, the other issue you opened may end up fixing this, but lets leave this open until the problem that @xMartin describes is resolved.

Create `local.type` and `remote.type` to easily check which storage methods are being used.

It could be helpful to developers getting familiar with the library, for one, but also there could be some apps that want to report that info in a settings page...

Create `local.type` and `remote.type` to easily check which storage methods are being used.

It's just a benefit to having a clear and uncomplicated `rs` object, in both layout and intention. I do see the use in seeing those properties on the object itself,...