Seth Silesky
Seth Silesky
> > > > for example, I couldn't define a function on a post called delete without it casuing issues. > > > > ```js > > function Post() {};...
Having the same issue here: ``` import { assert } from 'chai'; import React from 'react'; import redux from 'redux'; import store from '../app/_Store.js'; import reducer from '../app/reducers/_Reducer.js'; import TestUtils...
I don’t know if there are any hard and fast rules about this. It is a good question of “where do you draw the line”? I think — since we...
> Please review the package.json with extra caution to make sure things are as they should be ‘yarn constraints’ FTW! It’s like linting for your package.json!
Pushed a commit that fixes constraints.
Thanks @chambo-e for reporting this. This seems reasonable that we want to augment JSON to allow undefined properties, as we assume that users understand that any undefined values are removed...
@zygopleuralI Thanks for taking out an issue. I wasn't able to reproduce -- ```ts // This works const traits: Record = {name: "hello"} analyics.identify("foo", traits) ``` https://www.typescriptlang.org/play?#code/JYWwDg9gTgLgBAbzgQQHYEMA2BPGwDGAzgEJQQDuhAplADQoY55FwC+cAZmSHAOQAC1AOYgqqGAHp0jXAUIBaVFQAeMXgChNm-BFSF4MKOmAxCALjgAlKjqgATADz6owVEPrPXQgHxwAvHCIGKIWAEQAFlSYmBChrADc6gAUCOzohAxYskQAlAB0wHZieBzYSaEcELH0hsamOVpAA FYI, the definition...
@zygopleural Thank you for the detail, that's an interesting one, and will be a problem if anyone attempts to coerce an object created with that pattern to a Record type....
@zygopleural fixed in ~~1.42.2~~ 1.42.3
FYI @zygopleural there is an open Typescript issue about this scenario / bug: https://github.com/microsoft/TypeScript/issues/48014