Seth Silesky comments

Results 51 comments of


Seth Silesky

Use destroy instead of delete

> > > > for example, I couldn't define a function on a post called delete without it casuing issues. > > > > ```js > > function Post() {};...

Find references server error: TypeError: Cannot read property 'getType' of undefined

Having the same issue here: ``` import { assert } from 'chai'; import React from 'react'; import redux from 'redux'; import store from '../app/_Store.js'; import reducer from '../app/reducers/_Reducer.js'; import TestUtils...

When do you inject vs. just import? (config)

I don’t know if there are any hard and fast rules about this. It is a good question of “where do you draw the line”? I think — since we...

Add analytics-react package

> Please review the package.json with extra caution to make sure things are as they should be ‘yarn constraints’ FTW! It’s like linting for your package.json!

Add analytics-react package

Pushed a commit that fixes constraints.

undefined as JSONValue

Thanks @chambo-e for reporting this. This seems reasonable that we want to augment JSON to allow undefined properties, as we assume that users understand that any undefined values are removed...

Argument of type `Record<string, string>` is not assignable to parameter of type `Traits | Callback | null | undefined`

@zygopleuralI Thanks for taking out an issue. I wasn't able to reproduce -- ```ts // This works const traits: Record = {name: "hello"} analyics.identify("foo", traits) ``` https://www.typescriptlang.org/play?#code/JYWwDg9gTgLgBAbzgQQHYEMA2BPGwDGAzgEJQQDuhAplADQoY55FwC+cAZmSHAOQAC1AOYgqqGAHp0jXAUIBaVFQAeMXgChNm-BFSF4MKOmAxCALjgAlKjqgATADz6owVEPrPXQgHxwAvHCIGKIWAEQAFlSYmBChrADc6gAUCOzohAxYskQAlAB0wHZieBzYSaEcELH0hsamOVpAA FYI, the definition...