Simon Hellsten
Simon Hellsten
A function field in a struct can still segfault (i.e. you don't get the nice error message, assuming it's the same bug) if any argument or the return value is...
Why not just use `memcmp`? String's `__eq__` already does and I believe that's what Python does too. I was thinking something like: ```mojo struct String(Sized, Stringable, IntableRaising, KeyElement, Boolable): """Represents...
The output from my code above has changed in the new nightly release. On my machine (before updating nightly) `print(String())` used to correctly print an empty string (until I do...
@VMois Thank you! I closed this PR before because I couldn't pass the tests (because I didn't know that the math package wasn't supported to use because of cyclic dependencies)....
> This is great, thank you! Do you think you could do a followup where you move the core logic to `StringRef` and delegate to that from both `String` and...
> If you don't mind, would you just give it a go, and let's see what breaks? If things don't work, I will take a look at those tickets. @laszlokindrat...
Ubuntu tests got stuck for 6 hours (but the macos ones passed). I'm closing + reopening this to rerun the tests.
> FYI I had to modify this internally to avoid the `memcmp` recursion. It's the same problem that necessitated the `_memcmp` workaround, and I did a similar workaround as well....
> Yes, unfortunately, although my understanding is that the code before your patch had a similar workaround. If you are interested, you can give it a try: the recursion probably...