siimav

KSP-RO fork should have a fix for all the leaks mentioned above + some additional ones.

This is now handled in the code of `CompleteContractRequirement` as well: > For example if the contract requires that another contract needs to be completed before it can be offered,...

At least for `maxSimultaneous` I think the player shouldn't be able to accept more instances than the limit so why check that for already accepted contracts? As for `maxCompletions` -...

I have revised the PR with the changes I mentioned in the previous comment. At least for the contracts in RP-1 this should mostly eliminate the need to run those...

You're free to include any of the RP1 extensions directly into CC. Just make sure to use a different name to prevent conflicts.

Another similar error report here: https://forum.kerbalspaceprogram.com/index.php?/topic/155700-173-181-realism-overhaul-v1281-17-april-2020/&do=findComment&comment=3856070 I wonder if it's somehow related to RSS using 16k textures.

I've seen 3 separate people getting the same crash and so far all of them have been using the 16k RSS textures.

Yeah, [that logging](https://github.com/jrbudda/KerbalEngineer/blob/4da62d481b0867e0fd74956d6e0093bb715cbfa6/KerbalEngineer/VesselSimulator/Simulation.cs#L896-L899) will most definitely cause random crashes. It isn't safe to call `Debug.Log` from any other thread than the main one.

All these parameters should get wrapped inside a VesselParameterGroup. Otherwise the completed state for some parameters will carry over from previous flight and depending on the order, can cause the...

A bit of a long shot but could be that this change fixes the issue: https://github.com/KSP-RO/ContractConfigurator/pull/5