Simon Hutchinson

Results 17 comments of Simon Hutchinson

Vaadin-gradle-plugin does not support Gradle Toolchains

@mvysny @mshabarov @mcollovati I forked the flow-gradle-plugin and rewrote it to support Gradle's Java toolchains. The code is just a proof of concept and is unsuitable for a PR. I...

Change Dependency recipes do not work with dependencies defined in jvm-test-suites

Thanks for getting back to me @timtebeek. I have created a [PR](https://github.com/openrewrite/rewrite/pull/4376) with the failing test.

Change Dependency recipes do not work with dependencies defined in jvm-test-suites

Thanks @shanman190. If someone could outline a high-level solution, along with any areas of potential difficulty, or point me to some specific areas to familiarize myself with, then I'd be...

Change Dependency recipes do not work with dependencies defined in jvm-test-suites

Thanks @shanman190. I will take a look

Change Dependency recipes do not work with dependencies defined in jvm-test-suites

@shanman190 The issue was that the dependencies block is not being picked up as a `DependencyHandlerSpec`. I have updated my [PR](https://github.com/openrewrite/rewrite/pull/4376/files). This is not a complete solution, but was sufficient...

Change Dependency recipes do not work with dependencies defined in jvm-test-suites

@shanman190 - Cool. That's a much better solution

Change Dependency recipes do not work with dependencies defined in jvm-test-suites

@shanman190 I have picked this issue up again as this PR https://github.com/openrewrite/rewrite/pull/4354 seems to have stalled, and we need this functionality. I have implemented the trait approach from above, and...

Change Dependency recipes do not work with dependencies defined in jvm-test-suites

Closing as fixed by https://github.com/openrewrite/rewrite/pull/4376

Create a failing test for dependency change in the jvm-test-suite DSL

No problem. I haven't stepped through yet. I am about to go on vacation for a week so will hopefully pick it up on my return unless someone else does.

Create a failing test for dependency change in the jvm-test-suite DSL

@shanman190 @ryanwalker - I am happy to wait for Ryan to complete his PR on ChangeDependency and then work for UpgradeDependency. Once we have a working solution, it should be...