Sigurd Meldgaard

Results 306 comments of Sigurd Meldgaard

> @sigurdm is this ready for review? (it's marked a draft, but maybe that was by accident?) Yeah - I marked it as draft until I added the color-handling -...

I'm going on 3 weeks vacation today. So don't expect responses before that.

I've rebased this, could you take another look?

Fixed the test, had to hack the analyze_snippets_code.dart tool a bit. There was also a bug if the example folder existed but had no pubspec.yaml - fixed that.

This should work, try ending the Uri with a '/' then `Uri.resolve` is supposed to do the right thing

I think I'm misunderstanding something. Why would it overwrite it? ```dart void main() { final path = 'abc/def'; final uri = Uri.parse('http://localhost:6060/grpc'); final uri2 = Uri.parse('http://localhost:6060/grpc/'); print(uri.resolve(path)); print(uri2.resolve(path)); } ```...

This is definitely a bug. Is this something you can reproduce consistently? If so, can you make a small repro? It would be very helpful for digging into this.

I believe this is (at least partially) working as intended (even though it a somewhat confusing design) Canceling the StreamSubcription does not signal cancellation of the call (it only stops...

@mkustermann I remember you have been arguing that cancelling the subscription should not cancel the request. But since it is single subscription, and given the documentation for StreamSubscription.cancel says that...

> @sigurdm Can you explain by what you mean "without dart:html" please ? I can try to elaborate a little: When dart is run on a mobile device as flutter...