Sid Vishnoi

Results 191 comments of Sid Vishnoi

Yeah. It'll be backward compat, and discouraged in docs only. No warning.

@marcoscaceres Can you tell what's the path for Google Chrome on Mac? On Linux, it was `/usr/bin/google-chrome`. Edit: Never mind. Figured it out.

Looks like karma-safari combo on GitHub action doesn't work well :disappointed:

Safari tests are now working, but failing due to some reason. Using the fork until https://github.com/karma-runner/karma-safari-launcher/pull/22 is merged and released. @marcoscaceres Can you check if these tests actually fail in...

> I'm worried that prepare() puts us back into a linear plugin execution order, although maybe the determinism of calling .prepare() might be good in places? All `prepare` calls are...

> Hooking into anything makes things fragile, as we've seen. I understand the concern, but I think the previous hooks were fragile as we exposed them everywhere without much thought....

Haven't tested real specs that would like to use `after-markdown` hook, but [respec.org/docs/src.html#L115-L125](https://github.com/marcoscaceres/respec.org/blob/9229a5484ef2dfaeebad2711b1e9c7b46100c22f/static/docs/src.html#L115-L125) could use it like this: diff: docs/src.html ```diff diff --git a/static/docs/src.html b/static/docs/src.html index 9c5375d..03418a3 100644 --- a/static/docs/src.html...

Also, please add `webrecorder` to the release script so it gets added to `./builds/respec-webrecorder.js` during release: https://github.com/w3c/respec/blob/740123075705afc1eae4093eac06c9b33255a2d1/tools/release.js#L363 And also to: https://github.com/w3c/respec/blob/740123075705afc1eae4093eac06c9b33255a2d1/tools/netlify.js#L13

Also: https://w3c.github.io/web-share/ when images fail to load ![image](https://user-images.githubusercontent.com/8426945/160574155-7fc7313f-e24c-406e-a75c-88b40b837c4e.png)

> Do we know what happened to tr-design dark mode proposal? https://github.com/w3c/tr-design/issues/241