respec icon indicating copy to clipboard operation
respec copied to clipboard

Allow custom GitHub repo for issues

Open xfq opened this issue 4 years ago • 6 comments

Is your feature request related to a problem? Please describe.

class="issue" data-number="1" only works for the repo in the configuration option github.

Describe the solution you'd like

It would be great if ReSpec supports embedding content of a GitHub issue in another GitHub repo.

Describe alternatives you've considered

Fill in the content of the issue directly and manually.

xfq avatar Apr 02 '21 06:04 xfq

In theory, it should be trivial to add this... as I'm pretty sure we used to support this functionality in the past.

marcoscaceres avatar Apr 06 '21 08:04 marcoscaceres

A data-github="owner/repo" as a companion for data-number=issueNumber might be a good?

sidvishnoi avatar Apr 06 '21 08:04 sidvishnoi

yeah, something like that would work... then it would be on a per-issue basis.

marcoscaceres avatar Apr 06 '21 11:04 marcoscaceres

I'm thinking of soft-deprecating (no warning) .issue[data-number="issueNumber"] and instead use data-issue="org/repo#issueNumber" for this feature.

data-issue="issueNumber" would then be equivalent to .issue[data-number="issueNumber"]. Authors won't need to add a .issue and we won't need to support data-github. data-number and data-github don't make sense without a .issue, so why not add a data-issue to merge them? WDYT @marcoscaceres?

sidvishnoi avatar Dec 21 '21 14:12 sidvishnoi

I like it... but there might be quite a few specs using <div class="issue" data-number="xxx">... maybe we can keep backwards compat? We can do a number check?

marcoscaceres avatar Dec 21 '21 14:12 marcoscaceres

Yeah. It'll be backward compat, and discouraged in docs only. No warning.

sidvishnoi avatar Dec 21 '21 14:12 sidvishnoi