Siddharth Kshetrapal

Results 301 comments of Siddharth Kshetrapal

Hi Evan! I noticed that docs uses an `a` tag inside ActionList, which gets the global link color which ActionList doesn't optimise for right now (links in ActionList do not...

Hi! Thanks for taking the time to open an issue, I have added it to our backlog to look into!

Hello again! Thanks for reporting this. I think this is because of our double rendered strategy for slots, we are tracking it here: https://github.com/primer/react/issues/1690

Hi! Sorry for taking forever to respond. I was able to download the zip file you gave and reproduce the type error. I have added it to the team's inbox...

I'd love to see `UnderNav` support [Button-ish API](https://primer.style/react/Button#counter-component) to add support `icon` /`leadingVisual`/ `counter` :) We have a design pattern, bake it in!

Should we bring back the template from [#1452 diff](https://github.com/primer/react/pull/1452/files#diff-01f9c9f0a87db01320bb5442c78f038f2873533c9428ea4d7532eb2bab5ac4fbR275)

Hi, thanks for reporting. We'll have a look! Thanks for including a repro! 💙

Hi! How do you feel about using the accessible ActionMenu instead of Popover here? https://primer.style/react/ActionMenu#with-a-custom-anchor example sandbox: https://codesandbox.io/s/ecstatic-knuth-kh1qen?file=/src/App.tsx https://user-images.githubusercontent.com/1863771/174782979-1007c521-4aaf-4ae6-af1f-1c13382c8a5a.mov

Yep, the design change is recent. Let me get @vdepizzol and @ashygee for comments as well. > I do feel very strongly that the Popover should have an auto-dismiss closeOnOutsideClick...

> I have moved forward with using ActionMenu for my current work though, without directional carets. That's great to hear. I'm going to keep this issue open for Popover and...