react icon indicating copy to clipboard operation
react copied to clipboard

Published 20 hours ago • verified publisher icon primer

`UnderlineNav` is missing examples for usage with icons/counters

Open maximedegreve opened this issue 2 years ago • 1 comments

While the CSS one has examples of usage with icons this React one doesn't.

Screenshot 2022-04-05 at 12 05 40

maximedegreve avatar Apr 05 '22 11:04 maximedegreve

I'd love to see UnderNav support Button-ish API to add support icon /leadingVisual/ counter :)

We have a design pattern, bake it in!

siddharthkp avatar Apr 05 '22 11:04 siddharthkp

Hi! This issue has been marked as stale because it has been open with no activity for 180 days. You can comment on the issue or remove the stale label to keep it open. If you do nothing, this issue will be closed in 7 days.

github-actions[bot] avatar Oct 02 '22 12:10 github-actions[bot]

Noting that the new UnderlineNav v2 (currently a draft that will replace the existing UnderlineNav upon completion) will support icons https://primer.style/react/drafts/UnderlineNav2#with-icons and counters https://primer.style/react/drafts/UnderlineNav2#loading-state-for-counters, thanks to @broccolinisoup! 😃

I'm going to update this issue to "closed as completed." Keep your eye on the Primer changelog for updates when the new UnderlineNav is fully released!

lesliecdubs avatar Oct 14 '22 03:10 lesliecdubs