Siddharth Kshetrapal

Results 301 comments of Siddharth Kshetrapal

@styfle There's great. That's going to help make it optional 🎉

Wow, how long has it been that way 😧 Would you like to dig in deeper to find why is not correctly set?

> I'd imagine something is missing in this project's package.json? Umm not really. Looks like the brotli package we use is not compatible with this flavor of unix 🤔 bundlesize...

🤔 I don't think this is something bundlesize should do. It can't replace the need for functional tests

> `bundlesize` and `maxSize` names kind of imply that this package checks everything about sizes I didn't try to imply that 😅 > I had a problem when empty css...

@shprink I've never used codefresh, so I don't have a need to add it, it would be useful if you can find the right implementation and put it here in...

@styfle Do you think the build should error out instead of passing if `brotli-size` is not installed? (Check out the result of the build) I have added you as a...

Whoops, this is terrible @karanjthakkar Ideas?

I like option 1 because it's the least amount of change

You'll need to port https://github.com/siddharthkp/github-build for semaphore and then we can use it 🙂