bundlesize icon indicating copy to clipboard operation
bundlesize copied to clipboard

Published 20 hours ago • verified publisher icon siddharthkp

BundleSize CircleCI Not Failing Build if bundle check fails

Open stevenfitzpatrick opened this issue 6 years ago • 3 comments

Do you want to request a feature or report a bug? Bug What is the current behavior? When BundleSize maxSize fails the process ends with Exit Code 0 instead of 1 If the current behavior is a bug, please provide the steps to reproduce. circleci com_gh_stevenfitzpatrick_stevenfitzpatrick io_4_utm_campaign vcs-integration-link utm_medium referral utm_source github-build-link

What is the expected behavior? Expect failed bundlesize run to exit with Exit Code 1 and cause a failed build. If this is a feature request, what is motivation or use case for changing the behavior?

Please mention other relevant information.

  • node version 8.9.1
  • npm version 5.5.1
  • Operating system
  • bundlesize version 0.15.3
  • CI you are using CircleCI

stevenfitzpatrick avatar Dec 08 '17 15:12 stevenfitzpatrick

Wow, how long has it been that way 😧

Would you like to dig in deeper to find why is not correctly set?

siddharthkp avatar Dec 09 '17 15:12 siddharthkp

Could you also paste the content of the test:size script in package.json? It could be as simple as || true in there, would be a shame to dig into this issue only to find out the problem was in the usage :-)

StephanBijzitter avatar Feb 07 '18 00:02 StephanBijzitter

Same here https://travis-ci.org/kenwheeler/cash/builds/510054291

image

:/

limonte avatar Mar 22 '19 23:03 limonte