Siddarth Kumar

Results 231 comments of Siddarth Kumar

> video demo doesn't look like production ready ? don't we have designs ? The Daap used for demo video is 1inch.io and its Image asset does not load properly...

@flexsurfer : Here are the designs https://www.figma.com/file/UQSs6JFVpYRhpgCimvVDPl/Swaps%2C-WalletConnect-%F0%9F%94%926-Dec-21?node-id=111%3A16654 Do you still concerns with the implementation? If yes can you please elaborate.

> Also, can I ask you to rebase this PR on the latest develop, please? Will Rebase on latest develop!

@qoqobolo : I have identified the fix for issue 1 and I am currently working on it. I will ping here once the fix is ready for testing. Thanks for...

need this component for https://github.com/status-im/status-mobile/issues/13439 I have done most of the work in the screen

Design issue 1 : The white border surrounding the online indicator needs to be thicker ;) Check screenshot below for comparison ![Screenshot 2022-08-22 at 6 31 07 PM](https://user-images.githubusercontent.com/64726664/185927424-233f80ae-f8d7-4527-ab0f-5ea44bd3ded3.png)

Question/ Design Issue 2 : Should there be more options for sizes in this component considering we see 5 different sizes ( 16,20,24,28,32,48,80) in figma and only 3(Big,Small and Medium...

@ibrkhalil : Design issue 1 The background color in dark mode does not have correct opacities for color type primary. ![Screenshot 2022-08-22 at 4 51 00 PM](https://user-images.githubusercontent.com/64726664/185909430-5af8f3c6-bd7a-4dbb-9d70-5e6aa8ad43d2.png)

@ibrkhalil : Design issue 1 The add emoji icon/button seems to have a very dark border which is not how it is seen in figma. Its either the border width...

@cammellos @ibrkhalil : I'll be taking this up for a quick Design Review