status-mobile icon indicating copy to clipboard operation
status-mobile copied to clipboard

Published 20 hours ago • verified publisher icon status-im

Feature/13140 add permissions management for wallet connect

Open siddarthkay opened this issue 2 years ago • 15 comments

fixes #13140

Summary

Review notes

PR to implement disconnecting an already connected wallet via wallet connect

Testing notes

  • connect a wallet via walletconnect by scanning the QR code.
  • you can now click on the three dots on the top right hand side of the wallet screen and find a new menu item added to the bottom popover sheet called "Manage app connections"
  • on tap of that option you get the popover to disconnect the connection.

Platforms

  • Android
  • iOS

Areas that maybe impacted

wallet connect

Functional
  • wallet / transactions
  • dapps / app browsing
Non-functional

may impact some network consumption

status: ready

siddarthkay avatar Jun 01 '22 06:06 siddarthkay

Jenkins Builds

Click to see older builds (81)
:grey_question: Commit :hash: Finished (UTC) Duration Platform Result
:x: 7f7ee2b7 #1 2022-06-01 06:52:39 ~24 sec ios :page_facing_up:log
:x: 7f7ee2b7 #1 2022-06-01 06:52:39 ~24 sec android :page_facing_up:log
:x: 7f7ee2b7 #1 2022-06-01 06:52:43 ~28 sec android-e2e :page_facing_up:log
:x: 0b3ff6d7 #2 2022-06-01 07:04:24 ~14 sec android :page_facing_up:log
:x: 0b3ff6d7 #2 2022-06-01 07:04:25 ~15 sec android-e2e :page_facing_up:log
:x: 0b3ff6d7 #2 2022-06-01 07:04:26 ~15 sec ios :page_facing_up:log
:x: 5fe6acdc #3 2022-06-02 11:05:04 ~15 sec android-e2e :page_facing_up:log
:x: 5fe6acdc #3 2022-06-02 11:05:08 ~14 sec android :page_facing_up:log
:x: 5fe6acdc #3 2022-06-02 11:05:08 ~14 sec ios :page_facing_up:log
:x: a62a5fcd #4 2022-07-01 10:04:38 ~17 sec ios :page_facing_up:log
:x: a62a5fcd #4 2022-07-01 10:04:46 ~25 sec android-e2e :page_facing_up:log
:x: a62a5fcd #4 2022-07-01 10:04:47 ~25 sec android :page_facing_up:log
:x: 6a61f256 #5 2022-07-11 12:55:34 ~13 sec ios :page_facing_up:log
:x: 6a61f256 #5 2022-07-11 12:55:35 ~14 sec android-e2e :page_facing_up:log
:x: 6a61f256 #5 2022-07-11 12:55:35 ~14 sec android :page_facing_up:log
:x: 9c04846e #6 2022-07-12 07:09:01 ~21 sec android-e2e :page_facing_up:log
:x: 9c04846e #6 2022-07-12 07:09:06 ~26 sec android :page_facing_up:log
:x: 9c04846e #6 2022-07-12 07:10:56 ~2 min ios :page_facing_up:log
:x: ced168c5 #7 2022-07-12 09:18:58 ~17 sec android-e2e :page_facing_up:log
:x: ced168c5 #7 2022-07-12 09:19:00 ~14 sec ios :page_facing_up:log
:x: ced168c5 #7 2022-07-12 09:19:13 ~27 sec android :page_facing_up:log
:x: ebd1a9e6 #8 2022-07-19 14:31:03 ~26 sec android :page_facing_up:log
:x: ebd1a9e6 #8 2022-07-19 14:31:13 ~36 sec android-e2e :page_facing_up:log
:x: ebd1a9e6 #8 2022-07-19 14:32:08 ~1 min ios :page_facing_up:log
:x: 72123c9c #9 2022-07-27 10:15:22 ~19 sec android-e2e :page_facing_up:log
:x: 72123c9c #9 2022-07-27 10:15:29 ~26 sec ios :page_facing_up:log
:x: 72123c9c #9 2022-07-27 10:15:33 ~29 sec android :page_facing_up:log
:x: 76483498 #10 2022-08-02 10:07:45 ~16 sec android-e2e :page_facing_up:log
:x: 76483498 #10 2022-08-02 10:07:46 ~16 sec android :page_facing_up:log
:x: 76483498 #10 2022-08-02 10:07:48 ~19 sec ios :page_facing_up:log
:x: 13819143 #11 2022-08-02 13:27:25 ~25 sec ios :page_facing_up:log
:x: 13819143 #11 2022-08-02 13:27:28 ~28 sec android :page_facing_up:log
:x: 13819143 #11 2022-08-02 13:27:46 ~46 sec android-e2e :page_facing_up:log
:x: 5ee1c26f #12 2022-08-02 13:33:59 ~23 sec ios :page_facing_up:log
:x: 5ee1c26f #12 2022-08-02 13:34:02 ~26 sec android-e2e :page_facing_up:log
:x: 5ee1c26f #12 2022-08-02 13:34:03 ~26 sec android :page_facing_up:log
:x: 34a1f45a #13 2022-08-02 13:38:06 ~15 sec android :page_facing_up:log
:x: 34a1f45a #13 2022-08-02 13:38:07 ~15 sec android-e2e :page_facing_up:log
:x: 34a1f45a #13 2022-08-02 13:38:08 ~17 sec ios :page_facing_up:log
:x: 3726fdd6 #14 2022-08-02 13:39:00 ~14 sec android :page_facing_up:log
:x: 3726fdd6 #14 2022-08-02 13:39:00 ~15 sec ios :page_facing_up:log
:x: 3726fdd6 #14 2022-08-02 13:39:02 ~16 sec android-e2e :page_facing_up:log
:x: da296ceb #15 2022-08-02 13:41:02 ~16 sec android-e2e :page_facing_up:log
:x: da296ceb #15 2022-08-02 13:41:04 ~18 sec android :page_facing_up:log
:x: da296ceb #15 2022-08-02 13:41:05 ~19 sec ios :page_facing_up:log
:x: d8a68648 #16 2022-08-02 13:46:48 ~20 sec android :page_facing_up:log
:x: d8a68648 #16 2022-08-02 13:46:50 ~19 sec ios :page_facing_up:log
:x: d8a68648 #16 2022-08-02 13:46:58 ~32 sec android-e2e :page_facing_up:log
:heavy_check_mark: cac36850 #17 2022-08-02 14:34:30 ~10 min android-e2e :package:apk :calling:
:heavy_check_mark: cac36850 #17 2022-08-02 14:34:39 ~10 min android :package:apk :calling:
:heavy_check_mark: cac36850 #17 2022-08-02 14:35:04 ~10 min ios :package:ipa :calling:
:heavy_check_mark: 05c63a93 #18 2022-08-02 16:30:20 ~9 min android-e2e :package:apk :calling:
:heavy_check_mark: 05c63a93 #18 2022-08-02 16:31:12 ~10 min ios :package:ipa :calling:
:heavy_check_mark: 05c63a93 #18 2022-08-02 16:31:43 ~10 min android :package:apk :calling:
:heavy_multiplication_x: 6b1339f3 #19 2022-08-03 14:35:23 ~9 min android :package:apk :calling:
:heavy_multiplication_x: 6b1339f3 #19 2022-08-03 14:35:31 ~9 min android-e2e :package:apk :calling:
:heavy_multiplication_x: 6b1339f3 #19 2022-08-03 14:36:46 ~10 min ios :package:ipa :calling:
:heavy_check_mark: 172d901c #21 2022-08-03 16:31:59 ~9 min android-e2e :package:apk :calling:
:heavy_check_mark: 172d901c #21 2022-08-03 16:32:14 ~9 min android :package:apk :calling:
:heavy_check_mark: 172d901c #21 2022-08-03 16:43:09 ~20 min ios :package:ipa :calling:
:heavy_check_mark: 172d901c #22 2022-08-08 09:47:21 ~10 min ios :package:ipa :calling:
:heavy_check_mark: fa4f123e #22 2022-08-08 12:45:41 ~8 min android-e2e :package:apk :calling:
:heavy_check_mark: fa4f123e #22 2022-08-08 12:45:51 ~9 min android :package:apk :calling:
:heavy_check_mark: fa4f123e #23 2022-08-08 12:46:58 ~10 min ios :package:ipa :calling:
:x: b0b24759 #24 2022-08-08 12:57:57 ~14 sec ios :page_facing_up:log
:x: b0b24759 #23 2022-08-08 12:57:57 ~14 sec android :page_facing_up:log
:x: b0b24759 #23 2022-08-08 12:58:08 ~24 sec android-e2e :page_facing_up:log
:heavy_check_mark: dd2705c6 #24 2022-08-08 13:08:50 ~8 min android-e2e :package:apk :calling:
:heavy_check_mark: dd2705c6 #24 2022-08-08 13:09:10 ~9 min android :package:apk :calling:
:heavy_check_mark: dd2705c6 #25 2022-08-08 13:10:50 ~10 min ios :package:ipa :calling:
:heavy_check_mark: 23f88d8d #25 2022-08-09 05:41:56 ~8 min android-e2e :package:apk :calling:
:heavy_check_mark: 23f88d8d #26 2022-08-09 05:43:23 ~10 min ios :package:ipa :calling:
:x: 04144e83 #26 2022-08-09 14:22:11 ~4 min android :page_facing_up:log
:x: 04144e83 #26 2022-08-09 14:22:23 ~4 min android-e2e :page_facing_up:log
:x: 04144e83 #27 2022-08-09 14:23:13 ~5 min ios :page_facing_up:log
:heavy_check_mark: a8d595ce #28 2022-08-10 06:44:19 ~9 min android-e2e :package:apk :calling:
:heavy_check_mark: a8d595ce #28 2022-08-10 06:44:24 ~9 min android :package:apk :calling:
:x: a8d595ce #29 2022-08-10 06:46:46 ~11 min ios :page_facing_up:log
:heavy_check_mark: bf57275b #29 2022-08-10 06:54:58 ~7 min android-e2e :package:apk :calling:
:heavy_check_mark: bf57275b #29 2022-08-10 06:56:32 ~9 min android :package:apk :calling:
:heavy_check_mark: bf57275b #30 2022-08-10 07:00:19 ~13 min ios :package:ipa :calling:
:grey_question: Commit :hash: Finished (UTC) Duration Platform Result
:heavy_multiplication_x: 127238aa #31 2022-08-10 09:38:38 ~11 min ios :package:ipa :calling:
:heavy_multiplication_x: 127238aa #30 2022-08-10 09:41:40 ~14 min android :package:apk :calling:
:heavy_multiplication_x: 127238aa #30 2022-08-10 09:43:14 ~16 min android-e2e :package:apk :calling:
:heavy_multiplication_x: e8b84b20 #31 2022-08-12 09:31:39 ~8 min android-e2e :package:apk :calling:
:heavy_multiplication_x: e8b84b20 #31 2022-08-12 09:32:46 ~9 min android :package:apk :calling:
:heavy_multiplication_x: e8b84b20 #32 2022-08-12 09:34:01 ~10 min ios :package:ipa :calling:

status-im-auto avatar Jun 01 '22 06:06 status-im-auto

hi @siddarthkay , please mark PR WIP also in title

Parveshdhull avatar Jun 03 '22 10:06 Parveshdhull

hey @siddarthkay any updates? this PR is a blocker for the next release

flexsurfer avatar Jul 25 '22 11:07 flexsurfer

Hi @flexsurfer : I have achieved the desired functionality in status-go and currently working on testing it with status-react. This is very close to completion.I Shall push the final code this week and assign it for review.

siddarthkay avatar Jul 25 '22 12:07 siddarthkay

https://user-images.githubusercontent.com/64726664/182362884-b3ac1659-f5a0-4a4b-abe5-83005eab0ad4.mov

we can now disconnect a wallet session.

Only case it does not work is when you sync sessions across devices.. that is a work in progress. Can that be made as a separate PR and is the current progress good enough for this milestone 1.20?

@cammellos @qoqobolo

siddarthkay avatar Aug 02 '22 11:08 siddarthkay

Only case it does not work is when you sync sessions across devices.. that is a work in progress. Can that be made as a separate PR and is the current progress good enough for this milestone ?

@siddarthkay Thanks again for your work!

And for the record, as we agreed on the planning call it would be okay to implement the syncing part separately as long as it doesn't introduce other issues (will be checked during testing).

qoqobolo avatar Aug 02 '22 13:08 qoqobolo

video demo doesn't look like production ready ? don't we have designs ?

flexsurfer avatar Aug 03 '22 14:08 flexsurfer

video demo doesn't look like production ready ? don't we have designs ?

The Daap used for demo video is 1inch.io and its Image asset does not load properly and it may give you an impression that something is incomplete but it is not. I have used the existing / approved components to showcase the connections popover. Perhaps this new video would showcase that below, here I connect session of zerion Daap.

https://user-images.githubusercontent.com/64726664/182658449-5ef2ef2c-bf7a-4147-bde1-7ce25e1f7866.mov

siddarthkay avatar Aug 03 '22 16:08 siddarthkay

@flexsurfer : Here are the designs https://www.figma.com/file/UQSs6JFVpYRhpgCimvVDPl/Swaps%2C-WalletConnect-%F0%9F%94%926-Dec-21?node-id=111%3A16654

Do you still concerns with the implementation? If yes can you please elaborate.

siddarthkay avatar Aug 05 '22 03:08 siddarthkay

93% of end-end tests have passed

Total executed tests: 87
Failed tests: 6
Passed tests: 81

IDs of failed tests: 702157,6263,702156,702155,702076,5315

Failed tests (6)

Click to expand
  • Rerun failed tests

    • Class TestOneToOneChatMultipleSharedDevices:

    1. test_1_1_chat_non_latin_message_to_newly_added_contact_with_profile_picture_on_different_networks, id: 5315

    Device 1: Find `ChatElementByText` by `xpath`: `//*[starts-with(@text,'® æ ç ♥')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']`
    Device 1: Find `Button` by `xpath`: `//*[@text="Today"]`
    critical/chats/test_1_1_public_chats.py:408: in test_1_1_chat_non_latin_message_to_newly_added_contact_with_profile_picture_on_different_networks [chat.verify_message_is_under_today_text(timestamp_message, self.errors) for chat in (self.chat_1, self.c

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    Class TestEnsStickersMultipleDevicesMerged:

    1. test_sticker_1_1_public_chat_mainnet, id: 702157

    Device 1: Double tap on: HomeButton
    Device 1: Find `HomeButton` by `xpath`: `//*[contains(@content-desc,'tab, 1 out of 5')]`
    critical/chats/test_1_1_public_chats.py:1123: in test_sticker_1_1_public_chat_mainnet [home.home_button.double_click() for home in (self.home_1, self.home_2)] critical/chats/test_1_1_public_chats.py:1123: in [home.home_button.double_cli

    Class: TestEnsStickersMultipleDevicesMerged

    Device sessions

    2. test_ens_mention_push_highlighted_public_chat, id: 702156

    Device 1: Double tap on: HomeButton
    Device 1: Find `HomeButton` by `xpath`: `//*[contains(@content-desc,'tab, 1 out of 5')]`
    critical/chats/test_1_1_public_chats.py:1089: in test_ens_mention_push_highlighted_public_chat [home.home_button.double_click() for home in (self.home_1, self.home_2)] critical/chats/test_1_1_public_chats.py:1089: in [home.home_button.d

    Class: TestEnsStickersMultipleDevicesMerged

    Device sessions

    3. test_ens_mention_nickname_1_1_chat, id: 702155

    Device 1: Double tap on: HomeButton
    Device 1: Find `HomeButton` by `xpath`: `//*[contains(@content-desc,'tab, 1 out of 5')]`
    critical/chats/test_1_1_public_chats.py:1056: in test_ens_mention_nickname_1_1_chat self.chat_1.home_button.double_click() ../views/base_element.py:110: in double_click [self.find_element().click() for _ in range(2)] ../views/base_element.py:110:

    Class: TestEnsStickersMultipleDevicesMerged

    Device sessions

    Class TestPublicChatBrowserOneDeviceMerged:

    1. test_browser_delete_close_tabs, id: 702076

    Device 1: Find `Button` by `xpath`: `//*[contains(@text, 'bbc.com')]/../../../../*[@content-desc='empty-tab']`
    Device 1: Tap on found: Button
    critical/test_public_chat_browsing.py:423: in test_browser_delete_close_tabs web_page.element_by_text_part(urls['bbc.com']).wait_for_invisibility_of_element() ../views/base_element.py:144: in wait_for_invisibility_of_element raise TimeoutException

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    Class TestCommandsMultipleDevicesMerged:

    1. test_1_1_chat_command_request_and_send_tx_stt_in_1_1_chat_offline, id: 6263

    Device 1: Click until `EditBox` by `accessibility id`: `chat-message-input` will be presented
    Device 1: Wait for text element `TransactionStatus` to be equal to `Confirmed`
    critical/chats/test_1_1_public_chats.py:200: in test_1_1_chat_command_request_and_send_tx_stt_in_1_1_chat_offline [message.transaction_status.wait_for_element_text(message.confirmed, wait_time=120) for message in critical/chats/test_1_1_public_chats.p

    Class: TestCommandsMultipleDevicesMerged

    Device sessions

    Passed tests (81)

    Click to expand

    Class TestKeycardTxOneDeviceMerged:

    1. test_keycard_relogin_after_restore, id: 700768

    Class: TestKeycardTxOneDeviceMerged

    Device sessions

    2. test_keycard_send_tx_sign_message_request_stt_testdapp, id: 700769

    Class: TestKeycardTxOneDeviceMerged

    Device sessions

    3. test_keycard_create_account_unlock_same_seed, id: 5689

    Class: TestKeycardTxOneDeviceMerged

    Device sessions

    4. test_keycard_send_tx_eth, id: 700767

    Class: TestKeycardTxOneDeviceMerged

    Device sessions

    5. test_keycard_wallet_recover_pairing_check_balance_after_offline_tx_history, id: 700770

    Class: TestKeycardTxOneDeviceMerged

    Device sessions

    Class TestGroupChatMultipleDeviceMerged:

    1. test_group_chat_push_system_messages_when_invited, id: 3994

    Class: TestGroupChatMultipleDeviceMerged

    Device sessions

    2. test_group_chat_highligted, id: 5756

    Class: TestGroupChatMultipleDeviceMerged

    Device sessions

    3. test_group_chat_join_send_text_messages_push, id: 700731

    Class: TestGroupChatMultipleDeviceMerged

    Device sessions

    4. test_group_chat_offline_pn, id: 3998

    Class: TestGroupChatMultipleDeviceMerged

    Device sessions

    5. test_group_chat_add_new_member_activity_centre, id: 700732

    Class: TestGroupChatMultipleDeviceMerged

    Device sessions

    6. test_group_chat_leave_relogin, id: 3997

    Class: TestGroupChatMultipleDeviceMerged

    Device sessions

    Class TestOneToOneChatMultipleSharedDevices:

    1. test_1_1_chat_text_message_edit_delete_push_disappear, id: 695843

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    2. test_1_1_chat_message_reaction, id: 6315

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    3. test_1_1_chat_emoji_send_reply_and_open_link, id: 5373

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    4. test_1_1_chat_image_send_save_reply, id: 6305

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    5. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 5310

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    6. test_1_1_chat_text_message_with_push, id: 6316

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    7. test_1_1_chat_delete_via_delete_button_relogin, id: 5387

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    8. test_1_1_chat_push_emoji, id: 6283

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    Class TestRestoreOneDeviceMerged:

    1. test_restore_set_up_wallet_sign_phrase, id: 700749

    Class: TestRestoreOneDeviceMerged

    Device sessions

    2. test_restore_account_migrate_multiaccount_to_keycard_no_db_saved_add_wallet_send_tx, id: 702189

    Class: TestRestoreOneDeviceMerged

    Device sessions

    3. test_restore_seed_phrase_field_validation, id: 700750

    Class: TestRestoreOneDeviceMerged

    Device sessions

    4. test_restore_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 700748

    Class: TestRestoreOneDeviceMerged

    Device sessions

    Class TestSendTxDeviceMerged:

    1. test_send_tx_eth_check_logcat, id: 700763

    Class: TestSendTxDeviceMerged

    Device sessions

    2. test_send_tx_custom_token_18_decimals_invalid_password, id: 700765

    Class: TestSendTxDeviceMerged

    Device sessions

    3. test_send_tx_token_8_decimals, id: 700764

    Class: TestSendTxDeviceMerged

    Device sessions

    4. test_send_tx_set_recipient_options, id: 700757

    Class: TestSendTxDeviceMerged

    Device sessions

    5. test_send_tx_sign_message_2tx_in_batch_tx_filters_request_stt_testdapp, id: 5342

    Class: TestSendTxDeviceMerged

    Device sessions

    Class TestCommandsMultipleDevicesMerged:

    1. test_1_1_chat_command_decline_eth_push_changing_state, id: 6265

    Class: TestCommandsMultipleDevicesMerged

    Device sessions

    2. test_1_1_chat_command_send_tx_eth_outgoing_tx_push, id: 6253

    Class: TestCommandsMultipleDevicesMerged

    Device sessions

    Class TestPairingSyncMultipleDevicesMerged:

    1. test_pairing_sync_clear_history, id: 702394

    Class: TestPairingSyncMultipleDevicesMerged

    Device sessions

    2. test_pairing_sync_contacts_block_unblock, id: 702196

    Class: TestPairingSyncMultipleDevicesMerged

    Device sessions

    3. test_pairing_sync_initial_profile_picture, id: 702392

    Class: TestPairingSyncMultipleDevicesMerged

    Device sessions

    4. test_pairing_sync_initial_bookmarks, id: 702393

    Class: TestPairingSyncMultipleDevicesMerged

    Device sessions

    5. test_pairing_sync_initial_contacts_blocked_users, id: 702194

    Class: TestPairingSyncMultipleDevicesMerged

    Device sessions

    6. test_pairing_sync_1_1_chat_message, id: 702198

    Class: TestPairingSyncMultipleDevicesMerged

    Device sessions

    7. test_pairing_sync_public_chat_add_remove, id: 702199

    Class: TestPairingSyncMultipleDevicesMerged

    Device sessions

    8. test_pairing_sync_initial_public_chats, id: 702195

    Class: TestPairingSyncMultipleDevicesMerged

    Device sessions

    9. test_pairing_sync_contacts_add_remove_set_nickname_ens, id: 702197

    Class: TestPairingSyncMultipleDevicesMerged

    Device sessions

    Class TestPublicChatMultipleDeviceMerged:

    1. test_public_chat_message_edit, id: 700734

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    2. test_public_chat_unread_messages_counter, id: 5360

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    3. test_public_chat_emoji_send_copy_paste_reply, id: 700719

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    4. test_public_chat_unread_messages_counter_for_mention_relogin, id: 700718

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    5. test_public_chat_delete_chat_long_press, id: 5319

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    6. test_public_chat_link_send_open, id: 700736

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    7. test_public_chat_mark_all_messages_as_read, id: 6270

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    8. test_public_chat_links_with_previews_github_youtube_twitter_gif_send_enable, id: 700737

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    9. test_public_chat_message_send_check_timestamps_while_on_different_tab, id: 5313

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    10. test_public_chat_message_delete, id: 700735

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    Class TestContactBlockMigrateKeycardMultipleSharedDevices:

    1. test_contact_block_unblock_public_chat_offline, id: 702176

    Class: TestContactBlockMigrateKeycardMultipleSharedDevices

    Device sessions

    2. test_contact_add_remove_mention_default_username_nickname_public_chat, id: 702175

    Class: TestContactBlockMigrateKeycardMultipleSharedDevices

    Device sessions

    3. test_keycard_command_send_tx_eth_1_1_chat, id: 702186

    Class: TestContactBlockMigrateKeycardMultipleSharedDevices

    Device sessions

    4. test_restore_account_migrate_multiaccount_to_keycard_db_saved, id: 702177

    Class: TestContactBlockMigrateKeycardMultipleSharedDevices

    Device sessions

    5. test_cellular_settings_on_off_public_chat_fetching_history, id: 702188

    Class: TestContactBlockMigrateKeycardMultipleSharedDevices

    Device sessions

    Class TestOnboardingOneDeviceMerged:

    1. test_onboarding_add_new_multiaccount_username_by_position_pass_validation, id: 700747

    Class: TestOnboardingOneDeviceMerged

    Device sessions

    2. test_onboarding_home_initial_popup, id: 700742

    Class: TestOnboardingOneDeviceMerged

    Device sessions

    3. test_onboarding_share_contact_address, id: 700743

    Class: TestOnboardingOneDeviceMerged

    Device sessions

    4. test_onboarding_backup_seed_phrase_restore_same_login_logcat, id: 700745

    Class: TestOnboardingOneDeviceMerged

    Device sessions

    5. test_onboarding_cant_sign_in_with_invalid_password_logcat, id: 700746

    Class: TestOnboardingOneDeviceMerged

    Device sessions

    6. test_onboarding_share_wallet_address, id: 700744

    Class: TestOnboardingOneDeviceMerged

    Device sessions

    Class TestWalletManagementDeviceMerged:

    1. test_wallet_manage_assets, id: 700758

    Class: TestWalletManagementDeviceMerged

    Device sessions

    2. test_wallet_add_account_seed_phrase_validation, id: 700762

    Class: TestWalletManagementDeviceMerged

    Device sessions

    3. test_wallet_add_hide_unhide_account_private_key, id: 700761

    Class: TestWalletManagementDeviceMerged

    Device sessions

    4. test_wallet_add_delete_watch_only_account, id: 700760

    Class: TestWalletManagementDeviceMerged

    Device sessions

    5. test_wallet_fetching_balance_after_offline_insufficient_funds_errors, id: 700766

    Class: TestWalletManagementDeviceMerged

    Device sessions

    6. test_wallet_add_account_generate_new, id: 700759

    Class: TestWalletManagementDeviceMerged

    Device sessions

    7. test_wallet_tx_history_copy_tx_hash_on_cellular, id: 700756

    Class: TestWalletManagementDeviceMerged

    Device sessions

    Class TestEnsStickersMultipleDevicesMerged:

    1. test_ens_command_send_tx_eth_1_1_chat, id: 702153

    Class: TestEnsStickersMultipleDevicesMerged

    Device sessions

    2. test_ens_purchased_in_profile, id: 702152

    Class: TestEnsStickersMultipleDevicesMerged

    Device sessions

    3. test_start_new_chat_public_key_validation, id: 702158

    Class: TestEnsStickersMultipleDevicesMerged

    Device sessions

    Class TestPublicChatBrowserOneDeviceMerged:

    1. test_public_chat_open_using_deep_link, id: 700739

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    2. test_browser_bookmarks_create_edit_remove, id: 702077

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    3. test_browser_blocked_url, id: 702072

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    4. test_browser_connection_is_secure_not_secure_warning, id: 702073

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    5. test_browser_web3_permissions_testdapp, id: 702078

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    6. test_public_chat_tag_message, id: 700738

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    7. test_public_chat_navigate_to_chat_when_relaunch, id: 5396

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    8. test_public_chat_copy_and_paste_message_in_chat_input, id: 5317

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    9. test_public_chat_fetch_more_history, id: 5675

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    10. test_browser_offline, id: 702075

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    11. test_browser_invalid_url, id: 702074

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    status-im-auto avatar Aug 08 '22 09:08 status-im-auto

    100% of end-end tests have passed

    Total executed tests: 6
Failed tests: 0
Passed tests: 6

    Passed tests (6)

    Click to expand

    Class TestOneToOneChatMultipleSharedDevices:

    1. test_1_1_chat_non_latin_message_to_newly_added_contact_with_profile_picture_on_different_networks, id: 5315

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    Class TestPublicChatBrowserOneDeviceMerged:

    1. test_browser_delete_close_tabs, id: 702076

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    Class TestEnsStickersMultipleDevicesMerged:

    1. test_sticker_1_1_public_chat_mainnet, id: 702157

    Class: TestEnsStickersMultipleDevicesMerged

    Device sessions

    2. test_ens_mention_push_highlighted_public_chat, id: 702156

    Class: TestEnsStickersMultipleDevicesMerged

    Device sessions

    3. test_ens_mention_nickname_1_1_chat, id: 702155

    Class: TestEnsStickersMultipleDevicesMerged

    Device sessions

    Class TestCommandsMultipleDevicesMerged:

    1. test_1_1_chat_command_request_and_send_tx_stt_in_1_1_chat_offline, id: 6263

    Class: TestCommandsMultipleDevicesMerged

    Device sessions

    status-im-auto avatar Aug 08 '22 09:08 status-im-auto

    @siddarthkay

    ISSUE 1: The Manage app connections menu item disappears after relogin

    Although the wallet is still connected in a DApp. Thus, you can no longer manage your app connections after relogin. Not sure if it's expected, since other DApp permissions (in Profile > Privacy and security > Set DApp access permissions) keep displaying after relogin.

    Steps:

    1. Connect a wallet via walletconnect (tested on https://app.uniswap.org/)
    2. Re-login
    3. Open Wallet > open the three-dots menu

    OS: Android, iOS

    https://user-images.githubusercontent.com/67952253/183387777-7b0f65e2-b138-41ca-acb9-24702e9eb33c.mp4

    Also, can I ask you to rebase this PR on the latest develop, please?

    qoqobolo avatar Aug 08 '22 09:08 qoqobolo

    Also, can I ask you to rebase this PR on the latest develop, please?

    Will Rebase on latest develop!

    siddarthkay avatar Aug 08 '22 12:08 siddarthkay

    @qoqobolo : I have identified the fix for issue 1 and I am currently working on it. I will ping here once the fix is ready for testing.

    Thanks for reporting.

    siddarthkay avatar Aug 09 '22 10:08 siddarthkay

    @siddarthkay thanks for the update!

    qoqobolo avatar Aug 09 '22 10:08 qoqobolo

    Closing in favor of https://github.com/status-im/status-mobile/pull/13799

    cammellos avatar Aug 12 '22 16:08 cammellos