Volodymyr Shelmuk

Results 8 comments of Volodymyr Shelmuk

I would suggest [SlevomatCodingStandard.ControlStructures.DisallowYodaComparison](https://github.com/slevomat/coding-standard/blob/master/doc/control-structures.md#slevomatcodingstandardcontrolstructuresdisallowyodacomparison-). I think we discussed it internally and most part developers agreed that warning will be okay.

After internal discussion, the new approach with WordPress HTML API was implemented. The following points should be discussed additionally: 1. Do we consider the current change as a breaking change,...

@nlemoine Sorry for the delay, we have a vacation time :smile: will proceed as soon as possible

Thanks a lot for your fast feedback! > Don't use a separate ruleset. If this is only about excluding one sniff for a certain path, do that instead. Perhaps it's...

> We could install the `tsc` dependency globally in the reusable workflow itself via ` npm install -g typescript` - but normally you should have `typescript` defined in your `package.json`,...

I've rechecked the issue and tested https://github.com/WordPress/gutenberg/pull/62925 alongside pure https://typescript-eslint.io/ locally and in the GitHub action environment. It doesn't fix the original problem of checking types during linting. The https://github.com/typescript-eslint/typescript-eslint/issues/352#issuecomment-472597115...

I've invested time in checking how type-checking happens inside Gutenberg. The Gutenberg repository has "Static Analysis (Linting, License, Type checks...)" workflow with "Type checking" part - https://github.com/WordPress/gutenberg/blob/2e967be9e1928809841761744b4ed8c768f0a417/.github/workflows/static-checks.yml#L48-L49. This step `build:package-types`...

> you simply could loop over your packages by doing: The problem here is that you don't know whether `MyPackage\plugin()` exists. If the plugin is deactivated, you get fatal. This...