Shu Ding

Results 403 comments of Shu Ding

Love this, thank you! I think we want this PR to be in, but I'm currently a bit concerned about the current `text()` function being caused multiple times which causes...

Yes @unstubbable that's totally what I've been thinking about (sorry I missed your previous message). React will reconcile the node even the same node is passed to both fallback and...

> the other representing a value over time Could you point me to the place of this? I briefly check the React PRs and they all seem to represent a...

@unstubbable Yes I think we're on the same page :)

It's weird and I don't understand why renaming the file fixes it...

Image fallback is a nice feature, since browsers already have that for decades!

This is likely caused by different fonts' x height implementations.

Like it, although there're some tests that we need to update.

Changes look good to me but this might need to be landed in v3 as it's breaking.